351073 - Anti-phishing appearance problems when resizing window/sidebars

Status: RESOLVED WORKSFORME

(Toolkit :: Safe Browsing, defect)

Description

[Jackie Liu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2

There are multiple appearance problems when resizing/closing sidebars (Bookmarks/History) when the anti-phishing alert has been triggered.  It can sometimes cause part of the phishing page to appear.  This makes the UI look sloppy and should be fixed.

When closing sidebar:

http://www.flickr.com/photos/82706817@N00/231213733/

When resizing sidebar to be smaller:

http://www.flickr.com/photos/82706817@N00/231213735/

When resizing sidebar to be larger:

http://www.flickr.com/photos/82706817@N00/231213730/

Reproducible: Always

Steps to Reproduce:
1. Open a phishing page known to the anti-phishing filter.
2. Open the History or Bookmarks sidebar.
3. Resize the sidebar.  Notice the problems.
4. Close the sidebar. Notice the problem.

Comment 1

[Tony Chang (Google)]

On a side note, this isn't just from the sidebar, this happens anytime you resize the window.

Comment 2

[Jackie Liu]

(In reply to comment #1)
> On a side note, this isn't just from the sidebar, this happens anytime you
> resize the window.
> 

Thanks for the heads up.  Here's screenshots to cover that:

When resizing the window

http://www.flickr.com/photos/82706817@N00/231285307/

When maximizing the window

http://www.flickr.com/photos/82706817@N00/231281823/

Comment 3

[Adam Guthrie]

Did this regress recently? I was under the impression it was working... (I can't reproduce on Linux.)

Comment 4

[Tony Chang (Google)]

(In reply to comment #3)
> Did this regress recently? I was under the impression it was working... (I
> can't reproduce on Linux.)

Your computer may be too fast to repro.

Since we're using a canvas to make the dimmed overlay, it takes some time to render.  That time depends on things like the size of your browser window and how fast your machine is.

I'm not sure if there's much to be done to make it go faster other than maybe find an alternate way to create the dimming effect.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Not a blocker, this is how the feature works. Should make sure we take advantage of Cairo in Fx3 to make it look better, though.

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

Resolving since this is WFM using Firefox 4 and Firefox 2 is abandoned.