/motif should accept URLs that don't end in .css

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Rob Marshall [tH], Assigned: James Ross)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.79])

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
commands.js:1981:
             else if (e.motif.search(/\.css$/i) != -1)
             {
                 // specific css file

Would /^(https?|file):/ be a better pattern to use? (Assuming we don't need ftp: motifs, etc..)
(Assignee)

Comment 1

12 years ago
I'm sure someone will argue that it should try to create a URI via the IO Service and accept anything that doesn't throw.
(Assignee)

Updated

11 years ago
Assignee: rginda → silver
QA Contact: samuel → chatzilla
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 273160 [details] [diff] [review]
Allow file, http/s and ftp URLs

I went for allowing FTP just for safety; there's really no reason to disallow it.
Attachment #273160 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #273160 - Flags: review? → review?(samuel)

Updated

11 years ago
Attachment #273160 - Flags: review?(samuel) → review+
(Assignee)

Comment 3

11 years ago
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.79]
You need to log in before you can comment on or make changes to this bug.