clean up removeTab event dispatch mess

NEW
Unassigned

Status

()

Toolkit
XUL Widgets
12 years ago
12 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

There was some discussion about dispatching events when tabs are closed in bug 343096, and there was no complete resolution to that issue.

 ------- Comment #11 From neil@parkwaycc.co.uk  2006-08-13 09:46 PDT  [reply] -------

Well without auditing the code I guess there are four possibilities:
1) select events exactly match tab changes. This means that moving the
TabSelect notification into tabbrowser will have no effect.
2) some tab changes don't generate select events, which is why removeTab calls
updateCurrentBrowser
3) some tab changes generate duplicate select events, which is why
updateCurrentBrowser checks that the browser isn't already current first
4) both 2) and 3)
In the latter cases, moving the TabSelect notification into tabbrowser will
make it more reliable and useful. Either way you can't lose :-)


------- Comment #12 From Asaf Romano (use mozilla.mano@ for email) 2006-08-31 07:19 PDT [reply] -------

(From update of attachment 228485 [details] [diff] [review] [edit])
OK, this will do for now. I would really like to see this on the branch before
extensions start relying on the new tabbox event.

Please file a bug on cleaning up the removeTab mess.
No longer depends on: 343096
You need to log in before you can comment on or make changes to this bug.