Closed Bug 351133 Opened 18 years ago Closed 18 years ago

Options>Feeds "Choose Application..." button is cut off and scroll-bar appears.

Categories

(Firefox :: Settings UI, defect, P2)

Product:
Firefox
Component:
Settings UI
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: bugmozz, Assigned: asaf)

References

Details

(Keywords: access, fixed1.8.1, polish)

Attachments

(1 file)

patch for both issues
5.66 KB, patch
mconnor
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
with win XP default Theme, standard font size, Japanese language.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2 ID:2006090103
http://img134.imageshack.us/img134/3136/feedprefxo7.jpg

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901
BonEcho/2.0b2 ID:2006090116
http://img176.imageshack.us/img176/8335/preffi3.jpg
Assignee: nobody → bugs.mano
Flags: blocking-firefox2?
Priority: -- → P2
Summary: Options>Feeds "Choose Application..." button is cut off and scroll-bar appears. → "Choose Application..." button is cut off if the readers list is scrollable
Target Milestone: --- → Firefox 2
Status: NEW → ASSIGNED
*** Bug 351149 has been marked as a duplicate of this bug. ***
Keywords: regression
Keywords: regression
Restoring old summary now the I understand what's going on here.
Summary: "Choose Application..." button is cut off if the readers list is scrollable → Options>Feeds "Choose Application..." button is cut off and scroll-bar appears.
Workaround various listbox bugs.
Attachment #236650 - Flags: review?(mconnor)
Blocks: 350452
*** Bug 351241 has been marked as a duplicate of this bug. ***
Not a blocker, but good polish, and we'll probably take the patch.
Flags: blocking-firefox2? → blocking-firefox2-
Keywords: polish
Whiteboard: [would take patch]
Mano tells me that this is also an a11y issue, somehow.
Flags: blocking-firefox2- → blocking-firefox2+
Keywords: access
That's a very extensive patch. You do realize that

#chooseClientApp {
  -moz-margin-end: 20px;
}

in browser/preferences/preferences.css also does the job.
The patch here doesn't fix just the "cut off" problem, it also fixes the issue where we show a scrollbar for no reason.
Comment on attachment 236650 [details] [diff] [review]
patch for both issues

r=me.  thanks for writing the right fix, and not just the surface bug!
Attachment #236650 - Flags: review?(mconnor) → review+
Attachment #236650 - Flags: approval1.8.1?
Whiteboard: [would take patch] → [baking until 09/08]
mozilla/browser/components/preferences/feeds.js 1.7
mozilla/browser/components/preferences/feeds.xul 1.5
mozilla/browser/themes/pinstripe/browser/preferences/preferences.css 1.17
mozilla/browser/themes/winstripe/browser/preferences/preferences.css 1.16
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Blocks: 350672
Blocks: 350451
No longer blocks: 350451, 350672
Comment on attachment 236650 [details] [diff] [review]
patch for both issues

a=beltzner on behalf of 181drivers
Attachment #236650 - Flags: approval1.8.1? → approval1.8.1+
1.8 branch:
mozilla/browser/themes/pinstripe/browser/preferences/preferences.css 1.7.2.8
mozilla/browser/themes/winstripe/browser/preferences/preferences.css 1.6.8.8
mozilla/browser/components/preferences/feeds.js 1.1.2.7
mozilla/browser/components/preferences/feeds.xul 1.1.2.5
Keywords: fixed1.8.1
Whiteboard: [baking until 09/08]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: