Closed Bug 351145 Opened 18 years ago Closed 16 years ago

Selected entry not readable in unifinder or task list due to text/background color combination (if focus is moved away)

Categories

(Calendar :: Calendar Frontend, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: damian.publicemail, Assigned: ssitter)

References

Details

Attachments

(6 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060901 Calendar/0.3a2+

similar situation but different result

background color of selected element is the same but text color not

Reproducible: Always

Steps to Reproduce:
1. create event
2. select calendar in calendar panel
3. select event in unifinder
4. select event in main view

Actual Results:  
background color of selected event in unfinder is not the same like selected calendar in calendar panel

Expected Results:  
selection in unifinder should be the same like in calendar panel

some related problems that might help you
bug 248472
bug 326287
Attached image screenshot
Attached file default windows theme
problem happens for default theme
Version: unspecified → Trunk
Attached image Screenshot
The screen shot already on this bug doesn't show this problem very clearly so I have attached another one.
Summary: contrast: different algorithm for text color in calendars panel and unifinder → Selected event not readable in Unifinder due to text/background color combination (if focus is moved away from Unifinder)
Could this be as easy as altering the css?
Same issue applies to the new task list in today pane or task mode.
Summary: Selected event not readable in Unifinder due to text/background color combination (if focus is moved away from Unifinder) → Selected entry not readable in unifinder or task list due to text/background color combination (if focus is moved away)
We don't set any custom text colors in the unifinder therefore we should just stick to the default color for selected list entries. This patch removes the unnecessary style rule.

The task list needs a similar fix but that requires more attention to ensure that everything works correct for the status dependent coloring.
Attachment #344148 - Flags: review?(philipp)
Comment on attachment 344148 [details] [diff] [review]
[checked in] fix for unifinder

r=philipp
Attachment #344148 - Flags: review?(philipp) → review+
Attached patch fix for tasklistSplinter Review
For the tasklist we define different text and background colors dependent on status when focus is active. Therefore it works if we set the text color only if focus is set too. 

I'll attach a screenshot for WinXP but it would be good if someone could test on mac or linux too.
Attachment #344164 - Flags: review?(philipp)
Comment on attachment 344148 [details] [diff] [review]
[checked in] fix for unifinder

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c4ffaa7e2d73>

-> FIXED
Attachment #344148 - Attachment description: fix for unifinder → [checked in] fix for unifinder
Summary: Selected entry not readable in unifinder or task list due to text/background color combination (if focus is moved away) → Selected entry not readable in task list due to text/background color combination (if focus is moved away)
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Target Milestone: --- → 1.0
Comment on attachment 344164 [details] [diff] [review]
fix for tasklist

Nice work, looks good! r=philipp
Attachment #344164 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b22da03722e4>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Selected entry not readable in task list due to text/background color combination (if focus is moved away) → Selected entry not readable in unifinder or task list due to text/background color combination (if focus is moved away)
Checked in lightning build 2008102203557 and sunbird 20081022 -> VERIFIED
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.