Closed Bug 351155 Opened 14 years ago Closed 14 years ago

Win32 build with --enable-official-branding still uses generic branding partly

Categories

(Calendar :: Sunbird Only, defect)

x86
Windows 2000
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: mattwillis)

Details

(Whiteboard: [no l10n impact])

Attachments

(1 file)

I did a static Sunbird build (cleaned obj-dir before) with 
  BUILD_OFFICIAL=1
  MOZILLA_OFFICIAL=1
  ac_add_options --enable-official-branding
set. Afterwards I run "make installer" to build the NSIS installer.

OK:
Window title is Mozilla Sunbird and graphics in About dialog show Sunbird logo.
User agent shows Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060902 Sunbird/0.3a2+

Not OK:
Window and sunbird.exe uses generic calendar icon.
Installer build afterwards uses generic Calendar name and icon all over.
Fixes a number of Make-isms and friends that caused the generic branding.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #236544 - Flags: second-review?(dmose)
Attachment #236544 - Flags: first-review?(ssitter)
Comment on attachment 236544 [details] [diff] [review]
rev0 - fixes a number of errors

r1=ssitter
Attachment #236544 - Flags: first-review?(ssitter) → first-review+
Having the wrong branding blocks the release
Flags: blocking0.3+
Whiteboard: [patch in hand][needs review dmose][no l10n impact]
Comment on attachment 236544 [details] [diff] [review]
rev0 - fixes a number of errors

r=dmose with an added comment explaining where IDI_APPICON and friends are defined.
Attachment #236544 - Flags: second-review?(dmose) → second-review+
Whiteboard: [patch in hand][needs review dmose][no l10n impact] → [patch in hand][needs checkin][no l10n impact]
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs checkin][no l10n impact] → [no l10n impact]
You need to log in before you can comment on or make changes to this bug.