351167 - arrow does not change to finger over URL

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Leo Tick]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.0.6) Gecko/20060803 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.0.6) Gecko/20060803 Firefox/1.5.0.6

When the arrow cursor moves over a URL it chnges to a finger.
This is not happening in TB 1.5 OS2. OK in win.
On the lower bar the display reflects the URL but no finger.

Reproducible: Always

Steps to Reproduce:
1.move cursor over a URL
2.
3.

Actual Results:  
Arrow stays arrow

Expected Results:  
arrow should be finger

Comment 1

[Peter Weilbacher]

Indeed that is happening here, too, and still with TB 2.0.0.x and with TB from the current trunk.

It seems to be a build problem, the mouse shape for the different pointers is just not contained in the thunderbird executable.

Comment 2

[Peter Weilbacher]

Attachment: [checked in] Fix

This patches the files in mail/app similar to what Firefox and Sunbird already have, for TB it was probably just forgotten. The difference is that specifying a .def file breaks the compilation, so I left it out and it seems to work fine.

I think we can also remove widget/src/os2/resource.h from CVS. I'm still running a compilation to confirm that.

Comment 3

[Peter Weilbacher]

Attachment: [checked in] Remove unused widget/src/os2/resource.h

All other parts of the code that refer to resource.h point to another one (well, at least those that I found). A build succeeds without it.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 270483 [details] [diff] [review]
[checked in] Fix

r=mkaply

Comment 5

[Mike Kaply [:mkaply]]

I thought resource.h was still used for non static builds? Like seamonkey? where we look for the pointers/etc. in the DLL, not the EXE...

Comment 6

[Peter Weilbacher]

Then it should be referenced somewhere in widget\src\os2 but I don't see it there. Only wdgtos2rc.h is used and that contains the same stuff in resource.h. OK, it seems that the checkin
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2004-02-24+15%3A11&maxdate=2004-02-24+15%3A12
did the change but couldn't yet remove the file because of its usage elsewhere (like in mail/app).

But we can leave this part open until I have made another full build here, the FF debug builds I do are shared.

Comment 7

[Peter Weilbacher]

Comment on attachment 270483 [details] [diff] [review]
[checked in] Fix

Checked this into trunk. Leaving bug open for the resource.h patch.

Comment 8

[Peter Weilbacher]

mkaply, I now built a full SeaMonkey and it works fine without resource.h.

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 270502 [details] [diff] [review]
[checked in] Remove unused widget/src/os2/resource.h

r=mkaply

Comment 10

[Peter Weilbacher]

Comment on attachment 270502 [details] [diff] [review]
[checked in] Remove unused widget/src/os2/resource.h

Removed file on trunk.

Comment 11

[Peter Weilbacher]

Comment on attachment 270483 [details] [diff] [review]
[checked in] Fix

This has worked on trunk, so we also want it in the next branch release. (Well contained OS/2 only patch, I ask because I also change something in a cross-platform makefile.)

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 270483 [details] [diff] [review]
[checked in] Fix

approved for 1.8.1.7, a=dveditz for release-drivers

Comment 13

[Peter Weilbacher]

Checked in attachment 270483 [details] [diff] [review] to MOZILLA_1_8_BRANCH, so the official Thunderbird 2.0.0.7 release should have the fix.

Comment 14

[Peter Weilbacher]

Leo, could you get the current nightly build of Thunderbird from

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/contrib/latest-mozilla1.8/thunderbird-2.0.0.7pre.en-US.os2.zip

and see if the problem is fixed?

Comment 15

[Peter Weilbacher]

Leo confirmed to me by email that it is fixed for him, too. :-)