Closed Bug 351204 Opened 18 years ago Closed 18 years ago

Assertion on testcase in bug 344951

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: Waldo, Assigned: brendan)

References

Details

(Keywords: crash, regression)

Attachments

(1 file)

fix regression
1009 bytes, patch
brendan
: review+
Details | Diff | Splinter Review 
This is a regression, because it didn't assert (and indeed worked correctly) fairly recently; I'm unsure of the exact date but suspect it happened between now and 2006-08-31 (since I believe it worked when I was testing my first patch for bug 350629).
Regressed by patch for bug 351122.  Argh.

/be
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.8.1
Attached patch fix regression — — Splinter Review 
Taking the liberty of marking r+mrbkap.

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #236590 - Flags: review+
Attachment #236590 - Flags: approval1.8.1?
I'm going to land on the 1.8 branch too.

/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking1.8.1?
Resolution: --- → FIXED
I mean, I'll land the combined patch from bug 351122 and this patch, which I'll attach there in a minute.  Retracting nominations here.  This is a trunk-only bug.

/be
Blocks: 351122
Flags: blocking1.8.1?
Attachment #236590 - Flags: approval1.8.1?
testcase in bug 344951.
Flags: in-testsuite+
js1_7/block/order-of-operation.js
verified fixed 1.9 20060903 windows/mac*/linux
verified passed 1.8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: