App Update should create a System Restore Point on update

NEW
Unassigned

Status

()

defect
P3
normal
13 years ago
a month ago

People

(Reporter: slxception, Unassigned)

Tracking

(Blocks 1 bug)

1.8 Branch
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

I installed Firefox 2 beta 1, no problem.  When beta 2 came out, it installed the update with no problem.  A few days later, I needed to do a System Restore on Windows and reset my computer back a couple days.  When I next ran Firefox, it wanted to install the updated beta 2.  It couldn't do a partial upgrade, so it did a full install.  While it was downloading the full install, I checked the version info in Help|About and it showed Firefox beta 2 (just like the UA).  It caused no harm, but should be fixed.  Windows only bug

Reproducible: Always

Steps to Reproduce:
1.Install Firefox 2 beta 1, but do not install any upgrade yet
2.Create a system point in Windows.
3.Go to Help|Check for Upgrades in Firefox, and install Beta 2
4.After Firefox is installed, restore Windows to your system point
5. Start Firefox and check version info in Help|About
6. Go to Help|Check for Updates...

Actual Results:  
It asks to install an update to Firefox Beta 2, while in step 5, Firefox will say it is on beta 2

Expected Results:  
Step 6 should show "no upgrades possible".

Firefox should be more aware of the Windows Restore function.  It seems harmless, though can be disruptive as the browser will need to be restored twice.
I see this too, so -> NEW. Additionally I get a crash on start after the system restore (TB22929008Q), which seems to be password related. Safe mode works around that, but it was a brand new profile (and vmware install) so that's a little odd.

Another weird thing is that after the system restore, the User Agent from Help > About  is

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b2

which is correct for 2.0b1 except for the 2.0b2 at the very end.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 2.0 Branch
Looks like System Restore rolls back a bunch of dll's, exe's, master.ini from talkback and a random file from res/ that has a properties extension.

My guess is that the version for the update check comes from firefox.exe, while most of the content for Help > About comes from the chrome (untouched by SR).

I wonder if there is an opt out for SR.
(Assignee)

Updated

11 years ago
Product: Firefox → Toolkit
I have a working proof of concept of this. Creating a system restore point can take an indeterminate amount of time so I think we should display an indeterminate progress bar while creating the restore point as well as the appropriate text during this operation. Might be a good idea to have a way to disable creating the system restore point for nightly users since we could end up filling up the shadow copy and thereby kick out older restore points that are more critical. If it can be disabled I think a registry entry would be the best solution though I don't think there should be UI to set this key.
Summary: Firefox wants to reinstall itself after a System Restore → App Update should create a System Restore Point on update
I can work on this once the maintenance service has landed.
Assignee: nobody → netzen
Unassigned myself for now
Assignee: netzen → nobody
I'll take this... should be able to start on this in around two weeks
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

Updated

7 years ago
Removing tracking flag.  When this lands it will be on the Nightly channel at first which will be >= v16.  v13 is already released.

Comment 8

7 years ago
Is Firefox interfering with my vista system restore.  I was away and unplugged for about 7 months and now I cannot get a system restore (I get error..."unable to complete" message) and reading these entries and unresolved issues am a lot scared to do anything.  I disabled Norton firewall when I tried to restore but still got message.  Any help here please?
Thanks
~~~pet
It is not interfering with your Windows Vista system restore. Firefox currently does absolutely nothing with system restore. I suggest you ask for help in one of the forums that provides Windows help.
It's unlikely that I will get to work on this in the next two weeks, so unassigning myself for now.
Assignee: robert.strong.bugs → nobody
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
No assignee, updating the status.
No assignee, updating the status.

Updated

a month ago
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.