351253 - Search button misinterprets modifiers when clicked

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Asaf Romano (gone)]

Search button misinterprets modifiers when clicked.

Ctrl+Click on the search button doesn't open the search results in a new tab, Shift+Click (for a new window) doesn't work either. Note alt+click does open the page in a new tab, apparently by accident ;)

Comment 1

[Mike Connor [:mconnor]]

This isn't a blocker, but I'd be glad to see a patch in time for RC1.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 245619 [details] [diff] [review]
patch

>Index: browser/components/search/content/search.xml

>+            if (((aEvent && aEvent.altKey) ^ newTabPref))
>+              where = "tab";

nit: extra parentheses

>       <method name="doSearch">

>+          if (!submission)
>+            return;

Don't check submission here, if this is null then there's a bigger bug that I want to get an exception for (I should probably document this on the interface).

>+          var url = submission.uri.spec;
>+          postData = submission.postData;

Just declare postData here (or even use submission.* directly in the call to openUILinkIn).

Comment 4

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/components/search/content/search.xml 1.92