351318 - Keyboard shortcuts are not shown on menu items

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Stefan Sitter [:ssitter]]

Keyboard shortcuts are not shown on menu items

Steps to Reproduce:
1. Open any menu (e.g. 'File' menu)
2. Check menu items (e.g. 'Open Calendar File...')

Actual Results:
No keyboard shortcuts shown on menu items.

Expected Results:
Keyboard shortcuts are shown next to the menu items (e.g. 'Ctrl+O')

Additional Information:
Works in Sunbird/0.3a2+ (2006-09-03-07)
Fails in Sunbird/0.3a2+ (2006-09-04-02)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060904 Calendar/0.3a2+

Comment 1

[Stefan Sitter [:ssitter]]

Checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-09-03+06%3A00&maxdate=2006-09-04+03%3A00&cvsroot=%2Fcvsroot

Comment 2

[Stefan Sitter [:ssitter]]

This was caused by the check in for Bug 348304. I verified by backing out the changes to mozilla/layout/xul/base/src/*.

Because I'm not authorized to access Bug 348304 I'm adding the persons reported by Bonsai to CC here.

Comment 3

[Adam Guthrie]

This affect Firefox (and I'm assuming Thunderbird), too.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Yes. There is a patch for this in bug 348304.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Checked in an additional patch for bug 348304.
This should be fixed now.

Comment 6

[Stefan Sitter [:ssitter]]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060907 Calendar/0.3a2+

Comment 7

[Stefan Sitter [:ssitter]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060907 Calendar/0.3a2+
Verified with Thunderbird 3 alpha 1 (20060907)
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060907 Minefield/3.0a1

Comment 8

[Daniel Veditz [:dveditz]]

The fix for this bug has been merged into the branch patches for bug 348304, but I'm marking blocking so we can verify the branches don't regress.

Comment 9

[Reed Loden [:reed]]

Patches in bug 348304 were approved and checked-in. --> fixed1.8.0.9 / fixed1.8.1.1

Comment 10

[juan becerra [:juanb]]

Verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061129 Calendar/0.4a1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9pre) Gecko/20061128 Firefox/1.5.0.9pre
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1pre) Gecko/20061128 BonEcho/2.0.0.1pre

And latest Thunderbird on 1.8 and 1.8.0 (buildIDs: 20061129xx)