351362 - --with-java-include-path with spaces results in build failures

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Andrew Miller]

If you configure Mozilla with --with-java-include-path, and that path has spaces, e.g.:

ac_add_options --with-java-include-path="/cygdrive/c/Program Files/Java/jdk1.5.0_07/include"

this results in a compile line something like this:

/cygdrive/e/users/cmiss/physiome_builds/trees/mozilla_trunk/mozilla/build/cygwin-wrapper cl -FonsAppFileLocProviderProxy.obj -c  -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DZLIB_INTERNAL -DOSTYPE=\"WINNT5.1\" -DOSARCH=\"WINNT\" -DBUILD_ID=0000000000 -I/cygdrive/c/Program Files/Java/jdk1.5.0_07/include -I/cygdrive/c/Program Files/Java/jdk1.5.0_07/include/win32 -I/cygdrive/e/users/cmiss/physiome_builds/trees/mozilla_trunk/mozilla/extensions/java/xpcom/src -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/xulapp -I../../../../dist/include   -I../../../../dist/include/javaxpcom -I../../../../dist/include/nspr    -I../../../../dist/sdk/include       -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -FdnsAppFileLocProviderProxy.pdb  -DNDEBUG -DTRIMMED -O1 -MD            -D_CRT_SECURE_NO_DEPRECATE=1 -D_CRT_NONSTDC_NO_DEPRECATE=1 -DWINVER=0x500 -D_WIN32_WINNT=0x500 -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1 -DMOZ_XULRUNNER=1 -DMOZ_BUILD_APP=xulrunner -DMOZ_XUL_APP=1 -DMOZ_DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_SVG_FOREIGNOBJECT=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_ENABLE_LIBXUL=1 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cygdrive/e/users/cmiss/physiome_builds/trees/mozilla_trunk/mozilla/extensions/java/xpcom/src/../nsAppFileLocProviderProxy.cpp

Since there is a space in the path on the command line, but the argument doesn't get quoted, this results in a compilation failure.

Note that the path used is the default install path for Sun JDK.

Comment 1

[Benjamin Smedberg]

Didn't I *just* fix this in bug 350489?

Comment 2

[Gregory Szorc [:gps]]

While the build system still has problems with spaces in paths, --with-java-include-path is no longer a configure option. So this bug is invalid.