Closed Bug 351363 Opened 19 years ago Closed 19 years ago

overlays to customizeToolbar.xul should also apply to the sheet implementaion

Categories

(Firefox :: Toolbars and Customization, defect, P1)

2.0 Branch
PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox 2

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

We really don't have to break all the extensions out there for the sheet implementation.
Blocks: 351185
Status: NEW → ASSIGNED
Depends on: 350129
Flags: blocking-firefox2?
OS: Windows XP → Mac OS X 10.4
Priority: -- → P1
Hardware: PC → Macintosh
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
Flags: blocking-firefox2? → blocking-firefox2+
*** Bug 352189 has been marked as a duplicate of this bug. ***
Attached patch patch (obsolete) — Splinter Review
I was pondering making the whole thing an overlay, but figured this would be an overkill for something I'm planning to rewrite anyway.
Attachment #237870 - Flags: review?(mconnor)
Attached patch patchSplinter Review
Attachment #237870 - Attachment is obsolete: true
Attachment #237871 - Flags: review?(mconnor)
Attachment #237870 - Flags: review?(mconnor)
Comment on attachment 237871 [details] [diff] [review] patch r=me, should have got this earlier!
Attachment #237871 - Flags: review?(mconnor) → review+
Whiteboard: [has patch][checkin needed]
Attachment #237871 - Flags: approval1.8.1?
Comment on attachment 237871 [details] [diff] [review] patch a=schrep for drivers.
Attachment #237871 - Flags: approval1.8.1? → approval1.8.1+
1.8 branch: mozilla/browser/base/jar.mn 1.95.2.11 mozilla/browser/base/content/browser.xul 1.268.2.65 mozilla/extensions/reporter/jar.mn 1.4.4.3
Keywords: fixed1.8.1
trunk: mozilla/browser/base/jar.mn 1.105 mozilla/browser/base/content/browser.xul 1.318 mozilla/extensions/reporter/jar.mn 1.7
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][checkin needed]
Could this have caused bug 352476 ?
*** Bug 351185 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: