Closed Bug 351365 Opened 14 years ago Closed 14 years ago

Talkback won't install for new installs when DOMi is not present in the installer

Categories

(Toolkit :: NSIS Installer, defect)

1.8 Branch
x86
Windows XP
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: verified1.8.1)

Attachments

(3 obsolete files)

Patches for Firefox, Thunderbird, and Sunbird coming up

Thanks to Henrik Skupin for emailing me about this bug.
Since Firefox's installer includes DOMi this doesn't affect Firefox but I want to keep the code consistent across the apps... at least until I can come up with a sane way of moving the common code into toolkit.
Attachment #236757 - Flags: first-review?(sspitzer)
Attachment #236758 - Flags: first-review?(mscott)
Attachment #236758 - Flags: approval-thunderbird2?
Attachment #236759 - Flags: first-review?(mattwillis)
Comment on attachment 236759 [details] [diff] [review]
patch - Sunbird (checked in to trunk and branch)

r1=lilmatt
Attachment #236759 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 236757 [details] [diff] [review]
patch - Firefox (checked in to trunk and branch)

r=sspitzer
Attachment #236757 - Flags: first-review?(sspitzer) → first-review+
Comment on attachment 236757 [details] [diff] [review]
patch - Firefox (checked in to trunk and branch)

Simple fix for installing talkback properly when DOMi isn't present.
Attachment #236757 - Flags: approval1.8.1?
Attachment #236757 - Attachment description: patch - Firefox → patch - Firefox (checked in to trunk)
Attachment #236759 - Attachment description: patch - Sunbird → patch - Sunbird (checked in to trunk and branch)
Attachment #236759 - Attachment is obsolete: true
Comment on attachment 236758 [details] [diff] [review]
patch - Thunderbird (checked in to trunk and branch)

this looks pretty straight forward.
Attachment #236758 - Flags: first-review?(mscott)
Attachment #236758 - Flags: first-review+
Attachment #236758 - Flags: approval-thunderbird2?
Attachment #236758 - Flags: approval-thunderbird2+
Attachment #236758 - Attachment description: patch - Thunderbird → patch - Thunderbird (checked in to trunk and branch)
Attachment #236758 - Attachment is obsolete: true
All patches checked in to trunk.
Thunderbird and Sunbird patches checked in to MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 236757 [details] [diff] [review]
patch - Firefox (checked in to trunk and branch)

a=darin on behalf of drivers for the MOZILLA_1_8_BRANCH.
Attachment #236757 - Flags: approval1.8.1? → approval1.8.1+
Attachment #236757 - Attachment description: patch - Firefox (checked in to trunk) → patch - Firefox (checked in to trunk and branch)
Attachment #236757 - Attachment is obsolete: true
Checked in to MOZILLA_1_8_BRANCH
Work fine for latest installers for trunk and 1.8 branch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.