All users were logged out of Bugzilla on October 13th, 2018

Tab focus ring color is hardcoded

RESOLVED FIXED in Firefox 2

Status

()

P2
minor
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: dao, Assigned: mano)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2
x86
Windows XP
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change])

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060905 Minefield/3.0a1
Build Identifier: 

... that's bad especially for high-contrast OS themes.

I suggest this change to global/browser.css:

> /* tabbrowser-tab focus ring */
> .tabbrowser-tab >  .tab-image-middle > .tab-text {
>-  border: 1px dotted transparent;
>+  border: 1px dotted;
> }
> 
>-.tabbrowser-tab:focus > .tab-image-middle > .tab-text {
>-  border: 1px dotted black;
>+.tabbrowser-tab:not(:focus) > .tab-image-middle > .tab-text {
>+  border-color: transparent;
> }

Reproducible: Always
(Reporter)

Updated

12 years ago
Blocks: 347454
Whiteboard: [Fx2 theme change]
Version: unspecified → 2.0 Branch

Comment 1

12 years ago
Can you screenshot the effects this would have on "normal" and "high color" themes?
(Reporter)

Comment 2

12 years ago
Created attachment 236831 [details]
effect on normal and high contrast / black theme

Comment 3

12 years ago
I assume that's with your proposed change, right?  What about before it takes effect?

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 4

12 years ago
(In reply to comment #3)
> What about before it takes effect?

Well, border: 1px dotted black ... do you really need a screenshot for that?
Do we have a useful -moz color here, the logic is in reverse ;)
hrm, either ThreeDDarkShadow or -moz-DialogText.

Comment 7

12 years ago
(In reply to comment #6)
> hrm, either ThreeDDarkShadow or -moz-DialogText.

I'd assume DialogText... that's going to be visible for sure, whereas DarkShadow might be very hard to see in dark-background themes.
ThreeDDarkShadow is used for xul checkboxes for example, xfroms uses -moz-DialogText.

On bracnh, we can simply use "invert", but we will need to revise this once the new theme lands on trunk (Cairo has no "invert" concept).
(Reporter)

Comment 9

12 years ago
-moz-use-text-color?

Comment 10

12 years ago
Now that bug 350690 has landed, placing -moz-dialog behind all the tabs, using the color for dialog text would almost certainly work.  But is there a reason we don't want to just use whatever sets the color of the tab titles?  (Maybe that's dialog text too, I don't know.)
(Reporter)

Comment 11

12 years ago
(In reply to comment #10)
> Maybe that's dialog text too, I don't know.

Yes, it is:

http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/winstripe/global/tabbox.css#70

Comment 12

12 years ago
(In reply to comment #11)
> (In reply to comment #10)
> > Maybe that's dialog text too, I don't know.
> 
> Yes, it is

That seems like the way to go then... this would be a nice bit of High Contrast polish to take
Assignee: nobody → bugs.mano
Priority: -- → P2
Target Milestone: --- → Firefox 2
Comment on attachment 238099 [details] [diff] [review]
patch

very low risk, very high benefit a11y fix to themes
Attachment #238099 - Flags: review?(mconnor)
Attachment #238099 - Flags: review+
Attachment #238099 - Flags: approval1.8.1?
Attachment #238099 - Flags: approval1.8.1+
1.8 branch: mozilla/toolkit/themes/winstripe/global/browser.css 1.9.4.31
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.