Building trunk with GCC 3.2.2 on OS/2 fails in java_xpcom.c

RESOLVED FIXED

Status

Core Graveyard
Java to XPCOM Bridge
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

({fixed1.8.1})

Trunk
x86
OS/2
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

905 bytes, patch
jhp (no longer active)
: review+
Mike Schroepfer
: approval1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Following the checkin from bug 333618 java_xpcom.c does not compile any more on OS/2 with GCC 3.2.2:

I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c: In function 
`interface_declaration':
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: `PATH_MAX' undeclared 
(first use in this function)
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: (Each undeclared 
identifier is reported only once
I:/mozilla/xpcom/typelib/xpidl/xpidl_java.c:253: for each function it 
appears in.)

It seems that GCC 3.2.2 does not define MAX_PATH by default.
(Assignee)

Comment 1

12 years ago
Created attachment 236865 [details] [diff] [review]
the fix

This should fix it.

But I wonder if the same patch is needed for extensions/java/xpcom/tools/xpidl/xpidl_java.c.
Assignee: jhpedemonte → mozilla
Status: NEW → ASSIGNED
Attachment #236865 - Flags: review?(jhpedemonte)
(Assignee)

Updated

12 years ago
Blocks: 333618
Comment on attachment 236865 [details] [diff] [review]
the fix

Looks good.  None of the code in extensions/java/xpcom/tools is used any more after bug 333618, so don't worry about it.
Attachment #236865 - Flags: review?(jhpedemonte) → review+
(Assignee)

Comment 3

12 years ago
Checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

12 years ago
Comment on attachment 236865 [details] [diff] [review]
the fix

Not that the respective patch for bug 333618 went into MOZILLA_1_8_BRANCH we should get this in, too.
Attachment #236865 - Flags: approval1.8.1?

Comment 5

12 years ago
Comment on attachment 236865 [details] [diff] [review]
the fix

a=schrep for os2 build fix.
Attachment #236865 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.