Closed Bug 351499 Opened 14 years ago Closed 5 years ago

Sort out "delete calendar" vs. "unsubscribe" UI hilarity

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
4.0.0.1

People

(Reporter: mattwillis, Assigned: Fallen)

References

Details

Attachments

(1 file)

Right now we use "delete calendar" even when we truly mean "unsubscribe from calendar, but leave my data on the server alone".

We need better UI for this and more thought as to how to do this right.

Spinoff of bug 296202.
Blocks: 248309
IMO it blocks bug 263920
Blocks: 271399
Duplicate of this bug: 263920
(In reply to comment #0)
> Right now we use "delete calendar" even when we truly mean "unsubscribe from
> calendar, but leave my data on the server alone".
> 
[...]
talking of the storage calendar right now we're prompting: "Are you sure you want to unsubscribe from calendar <calendar_name>?" although it's getting deleted as Sebo correctly descibed in:
https://bugzilla.mozilla.org/show_bug.cgi?id=296202#c36

I'd vote for setting this one blocking 0.5 as this may lead to data loss.
Asking for blocking status, per Ulf's comment.
Flags: blocking-calendar0.5?
We're at string freeze without a patch.  Minusing for blocking-calendar0.5
Flags: blocking-calendar0.5? → blocking-calendar0.5-
Not going to make the 0.5 train.
Target Milestone: Sunbird 0.5 → ---
Flags: blocking-calendar0.7?
Nice to have, if a patch appears, but definitely not a blocker.
Flags: blocking-calendar0.7? → blocking-calendar0.7-
Makes sense for 0.8 w.r.t. bug 376585.
Berend, could you please take care of this one?
Flags: wanted-calendar0.8+
Flags: blocking-calendar0.7-
Flags: blocking-calendar0.5-
Not going to happen for 0.8.
Flags: wanted-calendar0.8+ → wanted-calendar0.8-
Needs to be fixed for 0.9.
Component: Internal Components → General
Flags: wanted-calendar0.8- → wanted-calendar0.9+
QA Contact: base → general
Version: Trunk → unspecified
Flags: wanted-calendar1.0+
Flags: wanted-calendar0.9+
Flags: blocking-calendar1.0?
This has lived over a couple of versions without many comments or complaints, therefore we shouldn't block 1.0 on it.

Bryan, could you nevertheless take a look at this bug? Maybe with a decent proposal its an easy bug to fix and we can take it for 1.0 after all.
Assignee: nobody → clarkbw
Flags: blocking-calendar1.0? → blocking-calendar1.0-
Assignee: clarkbw → nobody
Attached patch Fix - v1Splinter Review
I think its time...

This bug has strings, it needs to be in by Feb 23rd. If you don't have time to review/test the whole patch until then, I'd appreciate if you could at least review the strings and set f+ when you are happy.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8565167 - Flags: review?(mohit.kanwal)
Target Milestone: --- → 4.0
Comment on attachment 8565167 [details] [diff] [review]
Fix - v1

Review of attachment 8565167 [details] [diff] [review]:
-----------------------------------------------------------------

Applies on the tree and works as expected. Although I had difficulty running the tests: https://pastebin.mozilla.org/8822624
Attachment #8565167 - Flags: review?(mohit.kanwal) → review+
Pushed to comm-central changeset a39af5933cc1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
I've pushed a bustage fix for the tests. It seems mozmill is not running the latest js version, for-of did not work for me.

https://hg.mozilla.org/comm-central/rev/6c3dce69993b
You need to log in before you can comment on or make changes to this bug.