Closed
Bug 351528
Opened 18 years ago
Closed 18 years ago
Agenda fails on tasks that have date but no due date
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
Lightning 0.3
People
(Reporter: ssitter, Assigned: mattwillis)
Details
Attachments
(1 file)
|
2.82 KB,
patch
|
ssitter
:
first-review+
dmosedale
:
second-review+
|
Details | Diff | Splinter Review |
Task with date and without due date causes 'Error: ad has no properties' in agenda-tree.js Steps to Reproduce: 1. Create new task with start date but without due date 2. Check JavaScript Console / Error Console Actual Results: Error: ad has no properties Source File: chrome://lightning/content/agenda-tree.js Line: 356 Tbird/1.5.0.7 (20060905) + Ltn/0.1+ (2006090522-mozilla1.8)
|
Reporter | |
Comment 1•18 years ago
|
||
Hovering the mouse over Agenda causes Error: start has no properties Source File: chrome://lightning/content/agenda-tree.js Line: 189
|
|
Reporter | |
Comment 2•18 years ago
|
||
Adding another task causes Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [calIDateTime.compare]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://lightning/content/agenda-tree.js :: compare :: line 356" data: no] Source File: chrome://lightning/content/agenda-tree.js Line: 356
|
|
Reporter | |
Comment 3•18 years ago
|
||
Regression range: Works in Lightning/0.1+ (2006090406) Fails in Lightning/0.1+ (2006090506)
Flags: blocking0.3?
Summary: Task (with date, without due date) causes 'Error: ad has no properties' in agenda-tree.js → Agenda fails on tasks that have date but no due date
|
||
Updated•18 years ago
|
Flags: blocking0.3? → blocking0.3+
|
|
||
Comment 4•18 years ago
|
||
See bug 351598 comment 6 for a suggestion on how to fix this.
|
Assignee | |
Comment 5•18 years ago
|
||
This patch addresses the errors from comment 1 and comment 2. The hierarchy holds foo.entryDate least important. Basically, if we don't have a startDate or a dueDate, we'll use it rather than fail. If anyone wants this to make tomorrow's nightly, steal one of the reviews.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #238124 -
Flags: second-review?(dmose)
Attachment #238124 -
Flags: first-review?(ssitter)
|
|
Assignee | |
Updated•18 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Whiteboard: [needs review ssitter dmose]
Target Milestone: --- → Lightning 0.3
|
|
Reporter | |
Comment 6•18 years ago
|
||
Comment on attachment 238124 [details] [diff] [review] rev0 - adds entryDate r1=ssitter
Attachment #238124 -
Flags: first-review?(ssitter) → first-review+
|
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [needs review ssitter dmose] → [patch in hand][needs review dmose]
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 238124 [details] [diff] [review] rev0 - adds entryDate r=dmose
Attachment #238124 -
Flags: second-review?(dmose) → second-review+
|
|
||
Updated•18 years ago
|
Whiteboard: [patch in hand][needs review dmose] → [patch in hand][needs checkin]
|
|
Assignee | |
Comment 8•18 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•