351562 - Help viewer back/forward buttons are wrong in RTL mode (due to new theme)

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I can't for the life of me figure out why this patch doesn't entirely work. The computed style of the back button according to DOMi has "list-style-image: Toolbar-rtl.png", but the image shown in the toolbar is still Toolbar.png. I'm testing with global.dtd changed to "rtl" and ":root { direction: ltr;}" in my userChrome.css. If someone else could help me debug this I'd appreciate it, trying to work with a RTL DOMi is cramping my style :)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: Toolbar-rtl.png

Comment 3

[Asaf Romano (gone)]

The following kind of style rules cause this
 86 #help-back-button, 
 87 #help-forward-button[chromedir="rtl"] {
...
 90   -moz-image-region: rect(0px 24px 24px 0px); 
 91 }

Once you do provide a toolbar-rtl image (which is a good change), these rules don't make any sense (they take the forward image for the back button and vice-versa).

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Asaf Romano (gone)]

Attachment: patch

*argh*

Comment 7

[Asaf Romano (gone)]

Attachment: simplified

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 237035 [details] [diff] [review]
simplified

r+a=me, thanks!

Comment 9

[Asaf Romano (gone)]

1.8 branch:
mozilla/toolkit/themes/winstripe/help/Attic/Toolbar-rtl.png 1.1.2.1
mozilla/toolkit/themes/winstripe/help/help.css 1.12.2.7
mozilla/toolkit/themes/winstripe/help/jar.mn 1.6.4.3
mozilla/toolkit/components/help/content/help.xul 1.26.2.6

Comment 10

[Asaf Romano (gone)]

help.xul part landed on trunk:
mozilla/toolkit/components/help/content/help.xul 1.33

Comment 11

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).