Closed Bug 351575 Opened 14 years ago Closed 14 years ago

Dereference before null check in |nsTypedSelection::GetRangesForInterval|

Categories

(Core :: DOM: Selection, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: kherron+mozilla, Assigned: ispiked)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 2 obsolete files)

This is coverity ID 1025. Please see the sample URL. The variables |aResultCount| and |aResults| are dereferenced before the line that checks whether they're NULL.
Whiteboard: [good first bug]
Attached patch patch (obsolete) — Splinter Review
Assignee: selection → ispiked
Status: NEW → ASSIGNED
Attachment #237009 - Flags: superreview?(bryner)
Attachment #237009 - Flags: review?(brettw)
Comment on attachment 237009 [details] [diff] [review]
patch

Looks good, but please re-align the indented parameters to GetRangesForIntervalCOMArray with the first argument.
Attachment #237009 - Flags: review?(brettw) → review+
Just fixes the indentation, nothing else
Attachment #237666 - Flags: review?
Comment on attachment 237666 [details] [diff] [review]
AG's patch with fixed indentation

Karthik, I will attach a new patch to be checked in (with the indentation fix, of course) once bryner reviews the first patch.
Attachment #237666 - Attachment is obsolete: true
Attachment #237666 - Flags: review?
roger(In reply to comment #4)
> (From update of attachment 237666 [details] [diff] [review] [edit])
> Karthik, I will attach a new patch to be checked in (with the indentation fix,
> of course) once bryner reviews the first patch.
> 

roger
Attachment #237009 - Flags: superreview?(bryner) → superreview+
Attached patch patch v1.1Splinter Review
Attachment #237009 - Attachment is obsolete: true
Attachment #239811 - Flags: superreview+
Attachment #239811 - Flags: review+
Whiteboard: [good first bug] → [checkin needed]
Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v  <--  nsSelection.cpp
new revision: 3.266; previous revision: 3.265
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.