351583 - honor extensions.checkCompatibility when checking for updates and updating (first run)

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[logan]

Software update shows a "This update will cause some of your extensions and/or themes to stop working ..." message when updates are found and a "Checking your add-ons for compatibility ..." message after the update has been applied during the first run. Neither should be shown if extensions.checkCompatibility is set to false.

Are there other cases like this?

Comment 1

[logan]

Attachment: patch v1

Comment 2

[Dave Townsend [:mossop]]

I tend to disagree. The pref is really meant for testing purposes. While maybe the message could say something slightly different, I think its important to warn even testers that some of the extensions they have installed are not marked as compatible with the update they are installing.

Comment 3

[Robert Strong (they/them - no direct email)]

I've considered this previously and my current thinking is that we want the user to be informed that they have extensions that are not compatible when they are doing upgrades, etc. as well as checking for updates to these incompatible extensions when upgrading. At present I don't think we should do this.

Comment 4

[Robert Strong (they/them - no direct email)]

We definitely want to display the compatibility update wizard on upgrade even with the extensions.checkCompatibility pref set to false. We 'might' add strings for this but I prefer not adding one-off strings that are for cases like this. As I see it this bug could morph into adding the strings if you want to add them otherwise it is wontfix.

Comment 5

[Robert Strong (they/them - no direct email)]

Resoling -> wontfix per previous comments