351615 - When separator is selected, 'properties' and 'rename' button should be disabled

Status: RESOLVED DUPLICATE of bug 236696

(Firefox :: Bookmarks & History, defect)

Description

[Cheng Khoon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060906 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060906 BonEcho/2.0b2

In the bookmarks manager, when a bookmarks separator is selected, the 'Properties' and 'Rename' button should be disabled as there is no point giving a separator a name or a property.

Also, observe that if you rename a separator, the name will be appended in front of the separator in the bookmarks manager. The name does not appear in the bookmarks menu.

Reproducible: Always

Steps to Reproduce:
1. Open Bookmarks Manager through Menu > Bookmarks > Organize Bookmarks..
2. Select (highlight) a separator
3. Observe that the 'Properties' and 'Rename' toolbar buttons are still clickable.
4. Click on the 'Rename' button and give the separator a name.
5. Observe that the name is now appended in front of the separator.
Actual Results:  
'Properties' and 'Rename' toolbar buttons are clickable when a separator is selected. Also, you can rename a separator.

Expected Results:  
'Properties' and 'Rename' toolbar buttons should be disabled when a separator is selected.

Comment 1

[Phil Ringnalda (:philor)]

The bug (bug 236696, in fact) is that separator names don't appear in the menu, not that they exist in the bookmarks manager. And see the discussion there about removing it as useless-ui, ending up deciding not to.

*** This bug has been marked as a duplicate of 236696 ***