351626 - Decompiler can't make up its mind about whether if(lambda) needs extra parens

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jesse Ruderman]

js> function () {
    if (function () {}) {
        g();
    }
}
function () {
    if ((function () {})) {
        g();
    }
}

js> function () {
    if ((function () {})) {
        g();
    }
}
function () {
    if (function () {}) {
        g();
    }
}

Comment 1

[Brendan Eich [:brendan]]

More fallout from the generally righteous patch for bug 350531.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Again the thrust of the fix is to take advantage of the fix for bug 350531 and avoid forcing parentheses, instead letting the opcode precedence levels and the postfix-to-infix parenthesization magic in PopOff do their thing.  This requires making the lambda bytecodes have a lower precedence than the member operators.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk and 1.8 branch (force majeure again, last time if I can help it).

/be

Comment 4

[Bob Clary [:bc] (inactive)]

Checking in regress-351626.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-351626.js,v  <--  regress-351626.js
initial revision: 1.1

Comment 5

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 1.9 20060909 windows/mac*/linux