351706 - Decompiler can't make up its mind about whether parameterized E4X literals need parens

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> function() { return <{m}/>.(y) } 
function () {
    return (<{m}/>).(y);
}

js> function() { return (<{m}/>).(y) } 
function () {
    return <{m}/>.(y);
}

Comment 1

[Brendan Eich [:brendan]]

Sorry, I'm not going to fix this for js1.7/mozilla1.8.1/firefox2.

/be

Comment 2

[Brendan Eich [:brendan]]

Jeff, if you are interested in this, for 1.8.1 or any time, feel free to grab it.

/be

Comment 3

[Brendan Eich [:brendan]]

WFM now (the parens "stick"):

js> function() { return <{m}/>.(y) } 
function () {
    return (<{m}/>).(y);
}
js> function() { return (<{m}/>).(y) } 
function () {
    return (<{m}/>).(y);
}

Another fix as part of the decompiler party related to bug 346642?

/be

Comment 4

[Bob Clary [:bc] (inactive)]

Checking in regress-351706.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-351706.js,v  <--  regress-351706.js
initial revision: 1.1
done

Comment 5

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20061007 windows/linux, passes 1.8 too.