Closed
Bug 351729
Opened 19 years ago
Closed 19 years ago
UI polish & cleanup for Feed Preview
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 2
People
(Reporter: beltzner, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1)
Attachments
(5 files, 1 obsolete file)
|
12.43 KB,
image/png
|
Details | |
|
3.46 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
|
46.88 KB,
image/png
|
Details | |
|
39.68 KB,
image/png
|
Details | |
|
7.58 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
showing cramped UI on Mac
A couple of polish items here:
1. Remove the white background that appears behind the subscription options and buttons shown the first time through the subscription UI.
2. Always show the large RSS icon floated to the side of the subscription options, even after the first time through the subscription UI.
3. On Mac, the first two lines of the subscription UI look a little cramped; is there any way to add in a touch more space?
|
Reporter | |
Comment 1•19 years ago
|
||
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P2
Target Milestone: --- → Firefox 2
|
|
Assignee | |
Comment 2•19 years ago
|
||
Also fixes pretty busted RTL UI.
Attachment #237266 -
Flags: review?(mconnor)
|
|
Reporter | |
Comment 3•19 years ago
|
||
Blocking for the RTL issues; Mano, those should be fixed first, and the UI polish can be considered secondary (and non-blocking, as sad as that makes me!) :)
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Attachment #237584 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 5•19 years ago
|
||
Comment on attachment 237266 [details] [diff] [review]
winstripe part
Winstripe part needs some cleanup.
Attachment #237266 -
Attachment is obsolete: true
Attachment #237266 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 6•19 years ago
|
||
|
|
Assignee | |
Comment 7•19 years ago
|
||
|
||
Comment 8•19 years ago
|
||
Comment on attachment 237584 [details] [diff] [review]
pinstripe part
r+a=me on this straightforward Mac-only CSS change
Attachment #237584 -
Flags: review?(mconnor)
Attachment #237584 -
Flags: review+
Attachment #237584 -
Flags: approval1.8.1+
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
|
|
Assignee | |
Comment 9•19 years ago
|
||
Pinstripe part is in:
mozilla/browser/themes/pinstripe/browser/feeds/subscribe.css 1.1.2.11
Whiteboard: [checkin needed (1.8 branch)] → pinstripe is fixed.
|
|
Assignee | |
Comment 10•19 years ago
|
||
Attachment #238068 -
Flags: review?
|
|
Assignee | |
Updated•19 years ago
|
Attachment #238068 -
Flags: review? → review?(mconnor)
|
|
||
Comment 11•19 years ago
|
||
Comment on attachment 238068 [details] [diff] [review]
Winstripe fixes
r+a=me, thanks!
Attachment #238068 -
Flags: review?(mconnor)
Attachment #238068 -
Flags: review+
Attachment #238068 -
Flags: approval1.8.1+
|
|
Assignee | |
Comment 12•19 years ago
|
||
1.8 branch:
mozilla/browser/themes/winstripe/browser/feeds/subscribe.css 1.1.2.12
mozilla/browser/components/feeds/content/subscribe.xhtml 1.1.2.14
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.1
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: pinstripe is fixed.
|
|
Assignee | |
Comment 13•19 years ago
|
||
subscribe.xhtml part landed on trunk:
mozilla/browser/components/feeds/content/subscribe.xhtml 1.12
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•