[FIX] CreateTextNode does useless notifications

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
DOM
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9alpha1
x86
Linux
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

And as a result checks for mutation listeners for no reason.  And if there happen to be some, fires pointless mutation events....
Created attachment 237206 [details] [diff] [review]
Fix
Attachment #237206 - Flags: superreview?(bugmail)
Attachment #237206 - Flags: review?(bugmail)
Created attachment 237208 [details] [diff] [review]
With more cases covered
Attachment #237206 - Attachment is obsolete: true
Attachment #237208 - Flags: superreview?(bugmail)
Attachment #237208 - Flags: review?(bugmail)
Attachment #237206 - Flags: superreview?(bugmail)
Attachment #237206 - Flags: review?(bugmail)
Created attachment 237209 [details] [diff] [review]
Even compiles
Attachment #237208 - Attachment is obsolete: true
Attachment #237209 - Flags: superreview?(bugmail)
Attachment #237209 - Flags: review?(bugmail)
Attachment #237208 - Flags: superreview?(bugmail)
Attachment #237208 - Flags: review?(bugmail)
Comment on attachment 237208 [details] [diff] [review]
With more cases covered

Wanna check for the same thing in the sinks? At least SinkContext::AddComment in the htmlsink has the same problem
Attachment #237208 - Attachment is obsolete: false
Attachment #237208 - Flags: superreview+
Attachment #237208 - Flags: review+
Attachment #237209 - Flags: superreview?(bugmail)
Attachment #237209 - Flags: superreview+
Attachment #237209 - Flags: review?(bugmail)
Attachment #237209 - Flags: review+
Fixed.  Filed bug 351910 for the sinks.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
doesn't seem testable, or worth the effort to make it so
Flags: in-testsuite-

Comment 7

12 years ago
wait, we could test this... where are the sample documents, sicking?
Flags: in-testsuite- → in-testsuite?
You need to log in before you can comment on or make changes to this bug.