351744 - Memory leak in |inFileSearch::SetFilenameCriteria| (inFileSearch.cpp)

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Kenneth Herron]

This is coverity ID 244. Please see the sample URL. The allocation at line 274 is leaked if the test on the next line succeeds (i.e. the parser is at the end of the string being parsed).

Additionally, the writes into |buf| aren't bounds-checked, but I don't know if that's really a problem.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: 351744-1.diff

Comment 2

[Daniel Brooks [:db48x]]

Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

r=timeless via irc

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

sr=biesi

this code should really consider using break; instead of this going variable...

Comment 4

[Daniel Brooks [:db48x]]

Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

checked in to the trunk. requesting approval for the 1.8 branches

Comment 5

[Mike Schroepfer]

Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

181 is closed for RC1.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

Ok for FF2+, not worth bothering with in FF150x.
a=dveditz for drivers for checking into the 1.8 branch

Comment 7

[Daniel Veditz [:dveditz]]

Won't block on this, but will take for FF2+

Comment 8

[Daniel Brooks [:db48x]]

Checking in layout/inspector/src/inFileSearch.cpp;
/cvsroot/mozilla/layout/inspector/src/inFileSearch.cpp,v  <--  inFileSearch.cpp
new revision: 1.17.6.2; previous revision: 1.17.6.1