Closed Bug 351744 Opened 14 years ago Closed 14 years ago

Memory leak in |inFileSearch::SetFilenameCriteria| (inFileSearch.cpp)

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kherron+mozilla, Assigned: db48x)

References

()

Details

(Keywords: coverity, fixed1.8.1.1)

Attachments

(1 file)

This is coverity ID 244. Please see the sample URL. The allocation at line 274 is leaked if the test on the next line succeeds (i.e. the parser is at the end of the string being parsed).

Additionally, the writes into |buf| aren't bounds-checked, but I don't know if that's really a problem.
Attached patch 351744-1.diffSplinter Review
Attachment #237315 - Flags: review?
Attachment #237315 - Flags: review? → review?(timeless)
Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

r=timeless via irc
Attachment #237315 - Flags: superreview?(cbiesinger)
Attachment #237315 - Flags: review?(timeless)
Attachment #237315 - Flags: review+
Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

sr=biesi

this code should really consider using break; instead of this going variable...
Attachment #237315 - Flags: superreview?(cbiesinger) → superreview+
Assignee: dom-inspector → db48x
Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

checked in to the trunk. requesting approval for the 1.8 branches
Attachment #237315 - Flags: approval1.8.1?
Attachment #237315 - Flags: approval1.8.0.8?
Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

181 is closed for RC1.
Attachment #237315 - Flags: approval1.8.1? → approval1.8.1-
Flags: blocking1.8.1.1?
Comment on attachment 237315 [details] [diff] [review]
351744-1.diff

Ok for FF2+, not worth bothering with in FF150x.
a=dveditz for drivers for checking into the 1.8 branch
Attachment #237315 - Flags: approval1.8.1.1+
Attachment #237315 - Flags: approval1.8.0.9?
Attachment #237315 - Flags: approval1.8.0.9-
Won't block on this, but will take for FF2+
Flags: blocking1.8.1.1? → blocking1.8.1.1-
Checking in layout/inspector/src/inFileSearch.cpp;
/cvsroot/mozilla/layout/inspector/src/inFileSearch.cpp,v  <--  inFileSearch.cpp
new revision: 1.17.6.2; previous revision: 1.17.6.1
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.