Open Bug 351766 Opened 18 years ago Updated 2 years ago

Download dialog should display entire URL to file (and be selectable)

Categories

(Firefox :: File Handling, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: pete_a90, Unassigned)

References

Details

(Whiteboard: [CHE-BACKLOG])

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060907 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060907 Minefield/3.0a1

IMHO these two following changes should be made:

in:
/toolkit/mozapps/downloads/content/unknownContentType.xul

replace:
<description id="source"
with:
<textbox id="source" readonly="true"
remove:
crop="start"


in:
/embedding/components/ui/helperAppDlg/nsHelperAppDlg.js

replace:
location.value = pathString;
location.setAttribute("tooltiptext", this.mSourcePath);
with:
location.value = url.spec;


I have no idea why somebody went through all this effort to duplicate IE's inane behavior here.


Also, I think this displays user:password@ so that might be an issue over whether this change gets accepted as is or not. I'd prefer that behavior but since firefox devs are targeting grannies, I don't know if you guys want to have it show up.


Reproducible: Always
I'm thinking somewhere in between. We could make the tooltip of the location show the entire URL instead of omitting the filename like it does now. Continue to let the text show just the hostanme because extra long download URL's (read: MS download center) will break the dialog. Maybe make the hostname selectable. But remember, our biggest customers are former IE users and we need to make it as least daunting for them as possible.

I'll see if I can conjure up something. I have time on my hands. :)
I don't like the tooltip idea because sometimes random save file dialogs appear. I'd like to know the (copyable to clipboard!) full path to the URL before I do anything, especially if I'm doing "opening with" as opposed to "save to disk". And sometimes, I just want the complete URL to files (that are way too tedious to figure out from "view source") so I can paste them to friends or download manually with wget. If I save the file to disk I can get this information from right clicking on its entry in the download manager and going to properties, but in my opinion that is way too late and too many steps.

How do download centers URLs break the download dialog and do they also break the URL when viewing its properties in the download manager?
Attached image screenshot.png
With the latest Nightly (build ID: 20130813155809) on a Windows 7 64bit machine, while downloading http://www.bluej.org/tutorial/testing-tutorial.pdf I don't get the entire URL in the dialog, I only get http://www.bluej.org. 

Is this the issue you are refering to?

Please see the screenshot for details.
Flags: needinfo?
Flags: needinfo?
The bug still can be reproduced on Firefox 47 (As screenshoot).
To my knowledge, we're improving the download panel (Remove ALWAYS ASK dialog). Therefore, the bug will be fixed in the future.
Set as P2 (It means "Fix it in future release"), and assign a QA to verify it after patch lands on Nightly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Depends on: 1269956
Priority: -- → P2
Blocks: 1269956
No longer depends on: 1269956
See Also: → 338846
See Also: → 1270418
Whiteboard: [CHE-BACKLOG]
No longer blocks: 1269956
Confirm this problem in Firefox 60 too! Also will be good to see source url of downloaded file in Downloads page of Firefox interface! Why at now we can only copy it to clipboard, but can't preview it as text?
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: