351793 - Double-parenthesized object literal decompiles incorrectly.

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

js> function() { (({a:b, c:3})); } 
function () {
    {a:b, c:3};
}

Note that if I use only single parens around the object literal, it decompiles correctly, thanks to the fix for bug 351625.

Comment 1

[Brendan Eich [:brendan]]

Attachment: avoid redundant JSOP_GROUPs

Comment says it all.

Incomplete fix for bug 351625, I'll note the dependency for posterity in a sec.

/be

Comment 2

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 237343 [details] [diff] [review]
avoid redundant JSOP_GROUPs

This is safe and important for js1.7 -- we should not regress decompilation of object initializers, even if they are used as whole expression statements (this happens with JSON data used with eval/uneval).

/be

Comment 4

[Mike Schroepfer]

Comment on attachment 237343 [details] [diff] [review]
avoid redundant JSOP_GROUPs

a=schrep for drivers.

Comment 5

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-351793.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-351793.js,v  <--  regress-351793.js
initial revision: 1.1

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 1.9 20060909 windows/mac*/linux