Closed Bug 351811 Opened 18 years ago Closed 14 years ago

Marking spam as Junk fails to move it to Junk folder

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 487610

People

(Reporter: bob.lord, Unassigned)

References

(Blocks 1 open bug)

Details

version 2 alpha 1 (20060908)

I have my spam protection set to move spam to the Junk folder when I click on the Junk button.  Although the spam icon appears when I click that button, meaning that TB understands that this message is now junk, it does not move it to the Junk folder.

My mail server is an SSL/IMAP server.
Bob, any errors in the JS console?

This is working for me in the 09/08 thunderbird 2 nightly on Windows.

I went to Tools / Options /Privacy / Spam

and enabled the move to junk folder. Can you double check that it is set?

I'm guessing this just stopped working for you in todays build since you use the nightlies right?



(In reply to comment #1)
> Bob, any errors in the JS console?

Sigh.  You always ask this and I still forget to look.  Sorry.  I'm strangely free of spam this afternoon, but I'm sure tomorrow there'll be a fresh crop. :-)

> This is working for me in the 09/08 thunderbird 2 nightly on Windows.

I'll try Windows at home tonight.  I was on Linux when I reported this.

 
> I went to Tools / Options /Privacy / Spam
> 
> and enabled the move to junk folder. Can you double check that it is set?

Double checked.  


> I'm guessing this just stopped working for you in todays build since you use
> the nightlies right?

I had to delete my profile 1.x the other day in order to get 2.0 to even launch on Linux.  So I'm using a completely fresh profile. That was the other variable that changed, so I really don't know when this regression (assuming it's not pilot error) occurred.  And yes, I'm using the 2.0 nightly builds and I upgrade every day when the auto-updater kicks in.


Just checked on some new spam, and TB is exhibiting the same incorrect behavior on Linux.

I'm also going to test the "Delete them" feature to see if that's working any better.


Also, nothing in the error logs shows up.

I just tied the "Delete them" feature, and that works correctly.  So the only issue I'm running into is tied to the "move to Junk folder" option.


I just confirmed that the behavior I see on Linux is the same as on XP: Move to Junk folder does nothing, but Move to Trash works fine. 

I see nothing in my Error Log window.



Bob Lord, just to be sure: do you actually *have* a Junk folder created?
xref bug 352225
I do have a Junk folder (it's the same IMAP folder as I had before I had to recreate my TB profile).

I have a new theory, but I need another day to test it.  Our IMAP configuration here at work is a little odd in that the Inbox is the "root" of all other folders.  That means Drafts, Sent, Trash, etc. are all sub-folders under the Inbox.  Now, Sent, Trash, etc. all work correctly without me needing to do anything special.  

I wonder if somehow TB's spam system isn't able to figure that out, and is trying to create a new Junk folder as a peer of the Inbox.  Such an attempt would fail.  (If that's what it's doing, it should be sending an error to the error console, which it is not.)

Just now I manually set it to move spam to the Inbox/Junk folder, rather than to the generic Junk folder on that IMAP server.

I'll need a little more time to get some junk mail in.  It never shows up when I want it to.


I've confirmed that manually setting the Junk folder to be Inbox/Junk causes spam to be moved there.  

So then the bug is really "Drafts, Send, and Trash all work correctly as subcomponents of the Inbox, but the Junk folder does not".

What is different about the Junk folder?

(In reply to comment #7)
> I do have a Junk folder (it's the same IMAP folder as I had before I had to
> recreate my TB profile).

this might be the key. My experience with Bug 198727 is if TB does't find/recognize the special folder, as indicated by the proper junk folder icon, then messages won't get moved.  Folder existing and matching preference settings is not sufficient.  You method of fixing in comment 8 is what I also did.
I had to rebuild my profile again, and was able to determine that this bug still exists.


(In reply to comment #10)
> I had to rebuild my profile again, and was able to determine that this bug
> still exists.

Is that a followup to bug 352163 comment 12 & 13?  Could you state which build of the program you used to determine the bug is still an issue?
(In reply to comment #11)
> (In reply to comment #10)
> > I had to rebuild my profile again, and was able to determine that this bug
> > still exists.
> 
> Is that a followup to bug 352163 comment 12 & 13?  

No, but they may be related.  This bug is about spam not getting moved to the Junk folder when I hit the "Junk" button (manual tagging).

Bug 352163 is about spam not getting moved to the Junk folder automatically. 


> Could you state which build
> of the program you used to determine the bug is still an issue?


I'm running:
version 2 beta 1 (20061005) (Linux)

The client just updated itself to:
version 2 beta 1 (20061010)
so I'll keep an eye out to see if that helps. 



(In reply to comment #12)
> > > I had to rebuild my profile again, and was able to determine that this
> > > bug still exists.
> > 
> > Is that a followup to bug 352163 comment 12 & 13?  
> 
> No, but they may be related.  This bug is about spam not getting moved to the
> Junk folder when I hit the "Junk" button (manual tagging).
> 
> Bug 352163 is about spam not getting moved to the Junk folder automatically. 

Bug 352163 comment 12 suggests that bug is a dupe of bug 351545: turning on Junk controls in a new account doesn't automatically create the junk folder, so no junk is moved for any reason.  That's similar to what you've described at comment 7 here, and at bug 352163 comment 9.

One thing to check for is whether the junk folder specified in the account settings has the 'junk folder' icon.  Or, more detailed, in the Config Editor, see if the 'spamTarget' prefs exist for the account.

> > Could you state which build
> > of the program you used to determine the bug is still an issue?
> 
> I'm running:
> version 2 beta 1 (20061005) (Linux)
> 
> The client just updated itself to:
> version 2 beta 1 (20061010)
> so I'll keep an eye out to see if that helps. 

The fix for 351545 has been on the trunk (TB 3a1) for almost a week, but just got approved for the branch today.

Simply running a patched version isn't going to change the symptom; the fix applies when turning on the junk controls.  

Assuming you're seeing the problem of the junk folder not having the right icon, a way to test this is fixed without re-creating the account is: 
go to the account settings, turn off "Enable adaptive junk controls", close the settings window, re-open, and turn the option back on again -- without touching the folder-selection controls.  If after you do this, the folder gets the junk icon, then I think it's clear that both of your bugs are dupes of 351545.

As a simple workaround with an unpatched version, explicitly set the folder.  Again, if that fixes both bugs, then both bugs are dupes.
(In reply to comment #13) 
> Bug 352163 comment 12 suggests that bug is a dupe of bug 351545: turning on
> Junk controls in a new account doesn't automatically create the junk folder, so
> no junk is moved for any reason.  That's similar to what you've described at
> comment 7 here, and at bug 352163 comment 9.

This is an SSL/IMAP folder, and I previously had a working Junk folder (though I had to manually set the location for it to work).  So I'd hope for it to work now.  The one difference that may matter is that all my folders are children of the Inbox. I don't know what IMAP server we run here, but things like Drafts and Trash all live under Inbox.  But those other special folders work fine.  It's just Junk that fails to do the right thing.

 
> One thing to check for is whether the junk folder specified in the account
> settings has the 'junk folder' icon.  

I never noticed, but the Junk folder shows just a normal (secure) folder icon. Good catch!

> Or, more detailed, in the Config Editor,
> see if the 'spamTarget' prefs exist for the account.

I see no spamTarget pref, but I do see:
mail.server.default.spamActionTargetAccount
mail.server.default.spamActionTargetFolder

 
 
> Assuming you're seeing the problem of the junk folder not having the right
> icon, a way to test this is fixed without re-creating the account is: 
> go to the account settings, turn off "Enable adaptive junk controls", close the
> settings window, re-open, and turn the option back on again -- without touching
> the folder-selection controls.  If after you do this, the folder gets the junk
> icon, then I think it's clear that both of your bugs are dupes of 351545.
> 
> As a simple workaround with an unpatched version, explicitly set the folder. 
> Again, if that fixes both bugs, then both bugs are dupes.

I was really hoping that trick would do the trick, but it did not.

Does it matter that we use SSL here?

(In reply to comment #14)
> This is an SSL/IMAP folder, and I previously had a working Junk folder
> (though I had to manually set the location for it to work).  So I'd hope for
> it to work now.  

If you've got a new profile, you need to reset the junk folder in the profile; that's not implemented as a property on the IMAP server, AFAIK.


> > Or, more detailed, in the Config Editor,
> > see if the 'spamTarget' prefs exist for the account.
> 
> I see no spamTarget pref, but I do see:
> mail.server.default.spamActionTargetAccount
> mail.server.default.spamActionTargetFolder

I should have checked the names: those prefs, as you can see, are set for 'default' rather than for 'server2' (or whatever the serverN value is for your IMAP account).  As far as TB is concerned, there is no junk folder set for your account; the icon confirms only that that particular folder is not set as a junk folder.


> > As a simple workaround with an unpatched version, explicitly set the
> > folder.  Again, if that fixes both bugs, then both bugs are dupes.
> 
> I was really hoping that trick would do the trick, but it did not.

After you explicitly set the folder (and restarted) the icon did not change?
The spamActionTarget prefs didn't appear for that account?  Then it may well be that there's a different, IMAP-specific problem here; I can't say whether the patched version will fix it or not.


> Does it matter that we use SSL here?

To my knowledge, no.
(In reply to comment #15)
> (In reply to comment #14)
> > This is an SSL/IMAP folder, and I previously had a working Junk folder
> > (though I had to manually set the location for it to work).  So I'd hope for
> > it to work now.  
> 
> If you've got a new profile, you need to reset the junk folder in the profile;
> that's not implemented as a property on the IMAP server, AFAIK.

I could not get the icon to be set, so I closed TB and removed the Junk file in the IMAP folder in my profile.  When TB rebuilt that file, it also correctly set the icon. 


> 
> 
> > > Or, more detailed, in the Config Editor,
> > > see if the 'spamTarget' prefs exist for the account.
> > 
> > I see no spamTarget pref, but I do see:
> > mail.server.default.spamActionTargetAccount
> > mail.server.default.spamActionTargetFolder
> 
> I should have checked the names: those prefs, as you can see, are set for
> 'default' rather than for 'server2' (or whatever the serverN value is for your
> IMAP account).  As far as TB is concerned, there is no junk folder set for your
> account; the icon confirms only that that particular folder is not set as a
> junk folder.
> 
> 
> > > As a simple workaround with an unpatched version, explicitly set the
> > > folder.  Again, if that fixes both bugs, then both bugs are dupes.
> > 
> > I was really hoping that trick would do the trick, but it did not.
> 
> After you explicitly set the folder (and restarted) the icon did not change?
> The spamActionTarget prefs didn't appear for that account?  Then it may well be
> that there's a different, IMAP-specific problem here; I can't say whether the
> patched version will fix it or not.

After specifically setting the Junk folder, things are good.  I think that's what you were expecting me to find. 


I'm using Thunderbird version 1.5.0.7 (20060922) under Ubuntu Dapper and I have no longer this bug since I switched my imaps server simple name (blopsrv) to a FQDN  (blopsrv.mydomain.com) :

BUG :
my imaps server name : "blopsrv"

NO MORE THIS BUG :
my imaps server name : "blopsrv.mydomain.com"

Before I had this bug !
Hoping it will be helpful....
I'm now very confused.

I was still seeing this problem today (on XP).  Both settings of these settings failed to do anything:
"When I mark messages as junk: Delete them"
"When I mark messages as junk: Move them to the account's Junk folder"

In other words, I would have to mark a message as spam (which the client understood, properly showing the flaming junk icon), and then I would have to manually delete the message.

However, after fiddling with the options back and forth between the two settings a few times, both are now working! At least for now.

I see no errors on the Error Console. 

It this a timing bug?

I see this problem too. Thunderbird 2.0 beta 2, Linux. No IMAP here. I don't know if it's related but the error console shows :

Error: [Exception... "Component returned failure code: 0x80550008 [nsIMsgDBHdr.markHasAttachments]"  nsresult: "0x80550008 (<unknown>)"  location: "JS frame :: chrome://messenger/content/msgHdrViewOverlay.js :: anonymous :: line 452"  data: no]
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 452
I am unable to get manually marked junk to move automatically to the "junk" folder (the wastebasket) for pop3 collection using TB 2b2 running on Windows XP.
WIN XP SP2, TB Version 2.0.0.4 (20070604)
I think, the reason is in behalf of the time, TB needs to read, move by filter and download subject-lines: I have nearly 60000 emails, 350 rules (filter), 7 accounts, nearly 5 GB stored. These errors happened only, if I start TB and up to three hundred of emails are loaded down. After one hour or starting TB for the second or third time, moving the junk to the junk-folder runs quite right.
But: I'm reading from two different computers and after such problems the other PC has lost the sign for replication (look for new mails, set a sign, adjust the correct number of emails) and the changes are missed. I can force it by search a character in the subject-line from the in-coming mails with subfolders. After doing this I get the correct number and the correct Flags etc.!

Warm regards
Werner


I noticed a similar problem when using both thunderbird 1.5.x and 2.0.x. 
In the message list when I mark messages as spam by quickly clicking on the junk status column just moves the first messages marked.
If I have two messages one after another and I want to mark both as spam and I click on the junk status column for the first and then really quick click on the junk status for the next message it will mark both as spam but it will only move the first to the junk folder
Similar for core is Bug 217528
Hate to add a new bug to the junk mail controls myriad, but let me know if you all think this really needs to be a new bug:

 I'm using Seamonkey and seeing a failure of messages marked junk to move to a specified folder as they should when the option to enable adaptive junk mail controls is turned off.  I'm surprised I haven't seen more reports of this with the release of Gmail for IMAP.  Ideally, you should be able to disable the adaptive controls, but still be able to use the mark as junk feature to move items to the spam folder for teaching.  The current junk mail controls interface is currently set-up that way, but it doesn't work unless the adaptive controls are enabled.  One simple fix would be to have the other junk-mail options greyed out if adaptive controls is disabled, but I think the better solution would be to have the backend perform as the UI currently suggests.
Is this related to bug 324777?
more dependencies and bugs mentioned there, like bug 310431 for Seamonkey

consider also 
bug 196732
bug 310431
bug 168648

also, maybe related to bug 200594
Assignee: mscott → nobody
The odd thing for me, is that the Move to Junk folder works on other computers, just not my work machine...
I am seeing this bug on a pop 3 account on 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090926 Shredder/3.0pre
There's a couple of other bugs out there that might be dupes, when you try "junk move" as quicksearch.
Hardware: x86 → All
Blocks: junktracker
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.