351870 - unable to unselect single event from a group of selected events in main view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060908 Calendar/0.3a2+

it was not big problem if multiselection in main view was disabled, however because of bug 321384 it could be nice if I can select and unselect events using main view - right now it is supported only via unifinder

Reproducible: Always

Steps to Reproduce:
1. create two events
2. select first one (press it)
3. press CTRL and click second event
4. do not release CTRL and click again second event

Actual Results:  
second event is editable - I can modify title

Expected Results:  
second event should not be selected

Comment 1

[Stefan Sitter [:ssitter]]

(In reply to comment #0)

> Steps to Reproduce:
> 1. create two events
> 2. select first one (press it)
> 3. press CTRL and click second event

> Expected Results:
> second event should not be selected

I think CTRL+click was introduced to allow multiple selection. So I think this works as expected. Normal click on other events unselect the previous selected events too. I think the rest is covered with Bug 350951.

Comment 2

[Sebastian Schwieger]

This bug requests that a second Ctrl+Click deselects the event again. This is common behaviour in other applications (e.g. Windows Explorer) and makes sense if during a long selection-procedure one is picked by fault.
This is not covered by Bug 350951.

Comment 3

[Damian Szczepanik]

(In reply to comment #2)
> This bug requests that a second Ctrl+Click deselects the event again. This is
> common behaviour in other applications
exacly, it works how you described for unifinder so should be similar for main view
right now you can not deselect events using main view

Comment 4

[Stefan Sitter [:ssitter]]

*** Bug 355290 has been marked as a duplicate of this bug. ***

Comment 5

[Markus Adrario [:Taraman]]

I stumbled across the same issue.
I agree with Comments 2 & 3 that deselecting events should be possible.
Especially when you select a large number of events and misclick one shortly before being done - it is very annoying.

Since this is idle now for a long time: any comments on how we should handle this?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'd love to see this fixed as originally suggested, its nice polish. What currently happens on the second click is that the inline editing mode starts up. I guess you'd just need to make sure that event.ctrlKey is false when entering editing mode and also doublecheck that ctrl+click also removes an item from the selection.

Comment 7

[Markus Adrario [:Taraman]]

working on this bug showed me that the whole selection code seems to be quite buggy.

for example:
- if you click two events very quick after each other with ctrl pressed, the first event gets deselected, because the select-function only takes into account the currently selected items and no "pending selects"
- in day/multiday view, if you accidentally hit a grippy while "multiselecting", only the currently clicked event gets selected.
- events selected in the unifinder don't get selected in the views, because these don't handle the "itemselect" event.

Searching for existing bugs for this behaviour I stumbled across Bug 639447 which should help sorting out this problems.

For now I could just go ahead and adress the single problem from this bug in a small patch to get this solved at least.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Markus, I'd also not be sad if you would take over the patch I wrote over there ;-)

If you'd rather do small fixes now, go ahead and address the single problems as you mentioned.

Comment 9

[Markus Adrario [:Taraman]]

Attachment: allows deselection of items in views

This patch allows for deselection.

Philipp, I know your request queue is quite crowded. I'm just not sure if mschroeder or ssitter are doing reviews at the moment, because the entries in their queues are quite old.
Feel free to reassign review.

known issues: see comment #7
These are not caused nor addressed in this patch and will be treated in seperate bugs.

Comment 10

[Markus Adrario [:Taraman]]

Attachment: Patch V1.1

On trying further I discovered, that you can easily lose a whole selection, if you accidentally click on a free space in the view.

So added inhibition to that deselection logic when ctrl/meta is pressed.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 589050 [details] [diff] [review]
Patch V1.1

Review of attachment 589050 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp and approval for comm-aurora
Do you still have commit access, or is this checkin-needed?

::: calendar/base/content/calendar-view-core.xml
@@ +286,5 @@
>              }
> +            let items = this.calendarView.mSelectedItems.slice();
> +            if (event.ctrlKey || event.metaKey) {    
> +                if (this.selected) {
> +                    debugger;

One debugger statement slipped in

Comment 12

[Markus Adrario [:Taraman]]

(In reply to Philipp Kewisch [:Fallen] from comment #11)
> Do you still have commit access, or is this checkin-needed?
I had the reactivated hg-account reactivated the last days. I believe the rights are the same as before.

> > +                    debugger;
> 
> One debugger statement slipped in
oops. ;-)

Comment 13

[Markus Adrario [:Taraman]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/80959a308cf7>
Pushed to comm-aurora  <http://hg.mozilla.org/releases/comm-aurora/rev/23e01469104d>

-> FIXED