If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Regression, location bar no longer has accessible name

RESOLVED FIXED

Status

()

Core
Disability Access APIs
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, fixed1.8.1, regression})

1.8 Branch
x86
All
access, fixed1.8.1, regression
Points:
---
Bug Flags:
blocking1.8.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The location bar used to have the accessible name "Location".

Not sure what changed, but I suspect it's something in the XUL.
(Assignee)

Comment 1

11 years ago
Not sure why our QA didn't catch this one :( 
I just noticed it now while testing a different patch.
Flags: blocking-firefox2?
(Assignee)

Comment 2

11 years ago
I suspect this checkin: bug 337427
1.312 <joe@retrovirus.com> 2006-08-01 16:08
Hack to keep horizontal space from shifting between the urlbar and searchbar
when changing between a site that has RSS and/or SSL icons and one that
doesn't. It's not pretty, but it's the best solution we have now.
r=gavin, sr+branch=mconnor

We used to get the text via the <toolbaritem> but unfortunately our code in GetXULName() for that expects it to be the immediate parent. This checkin abouve makes it the grandparent.

Here's the code for GetXULName:
http://lxr.mozilla.org/seamonkey/source/accessible/src/base/nsAccessible.cpp#1733
(Assignee)

Comment 3

11 years ago
Created attachment 237499 [details] [diff] [review]
Make GetXULName() walk parent chain to find possible <toolbaritem>
Assignee: pilgrim → aaronleventhal
Status: NEW → ASSIGNED
Attachment #237499 - Flags: superreview?(neil)
Attachment #237499 - Flags: review?(ginn.chen)

Comment 4

11 years ago
Comment on attachment 237499 [details] [diff] [review]
Make GetXULName() walk parent chain to find possible <toolbaritem>

I wonder whether it's worth tweaking the loop slightly i.e.
for (; parent; parent = parent->GetParent(); )
Attachment #237499 - Flags: superreview?(neil) → superreview+
Blocks: 337427

Updated

11 years ago
Attachment #237499 - Flags: review?(ginn.chen) → review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Component: Disability Access → Disability Access APIs
Flags: review+
Flags: blocking-firefox2?
Product: Firefox → Core
Version: 2.0 Branch → 1.8 Branch
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 237499 [details] [diff] [review]
Make GetXULName() walk parent chain to find possible <toolbaritem>

a=mconnor on behalf of 181drivers (just marking this to reflect that)
Attachment #237499 - Flags: approval1.8.1+
(Assignee)

Comment 6

11 years ago
Comment on attachment 237499 [details] [diff] [review]
Make GetXULName() walk parent chain to find possible <toolbaritem>

The r=ginn.chen somehow got cleared, but it does have r+ from him.
Attachment #237499 - Flags: review+
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.