351955 - profileCreationExplanation_4.text in createProfileWizard.dtd needs a Linux/Gnome version

Status: RESOLVED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Marek Stępień [:marcoos, inactive]]

<!ENTITY profileCreationExplanation_4.text  "To begin creating your profile, click Next.">

The problem is that the "Next" button is called "Next" only on Windows and Linux in en-US.

Mozilla allows the l10n of this button separately for all of the three platforms:
http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/global/wizard.dtd#1

In other localizations it may be a bit different. For example, in Polish:
<http://lxr.mozilla.org/l10n-mozilla1.8/source/pl/toolkit/chrome/global/wizard.dtd>
we have "Dalej" for Windows and Mac, but "Naprzód" for Linux/Gnome.

The profileCreationExplanation_4.text entity should be forked into three: .textMac, .textWin and .textGNOME.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Actually, there's a Mac fork of this entity, so what this bug is really about is a Linux/GNOME fork.

Comment 2

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

Patch.

Haven't tested it yet, though.

Comment 3

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

Same thing, but from the root mozilla/ directory and with -u8pN.

Comment 4

[Marek Stępień [:marcoos, inactive]]

Resummarizing.

To make things clear, in en-US we have: 

win: Next
lin: Next
mac: Continue

in other locales, the Linux/Gnome version might not be equal to the Windows version, though, like in pl:

win: Dalej
lin: Naprzód
mac: Kontynuuj

This is why we need three and not just two versions of the "Click Next" string.

I've tested attachment 268334 [details] [diff] [review] on Mac OS X 10.4 and Ubuntu 6.10.

Comment 5

[Marek Stępień [:marcoos, inactive]]

Benjamin, do I need a sr for such a change?
If not, then I need someone to check this in. :)

Comment 6

[Kenneth Herron]

Checked in second patch. Clearing checkin-needed status.

Comment 7

[Marek Stępień [:marcoos, inactive]]

Resolving as fixed, then.