352011 - Decompilation needs to include parens for statements that begins with object literals

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jesse Ruderman]

js> function() { ({}.y = i); }
function () {
    {}.y = i;
}

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

This is a more general fix to the fix for bug 351625.

/be

Comment 2

[Brendan Eich [:brendan]]

*** Bug 352017 has been marked as a duplicate of this bug. ***

Comment 3

[Jesse Ruderman]

With this patch, an object literal in a "let" expression decompiles incorrectly.

./js -v 170

js> function() { let(x) ({t:x}) }
function () {
    let (x) {t:x};
}

Comment 4

[Jesse Ruderman]

Another example, similar to comment 3 but with the original parens around more code:

./js -v 170

js> function() { (let(x) {y: z}) }
function () {
    let (x) {y:z};
}

It's interesting that parens can be added in two places (around the object literal, or around the let block) to achieve the same result: making it be a let expression instead of a let block.

Comment 5

[Brendan Eich [:brendan]]

Fixed by patch for bug 352026.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-352011.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-352011.js,v  <--  regress-352011.js
initial revision: 1.1
done

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060914 windows/mac*/linux
bug not evident in 1.8...