Closed Bug 352043 Opened 14 years ago Closed 14 years ago

deadcode in nsBoxObject::GetOffsetRect

Categories

(Core :: XUL, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 obsolete file)

i can't find a path where parent could be null without crashing first.
Attached patch be daring (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #238879 - Flags: superreview?(neil)
Attachment #238879 - Flags: review?(neil)
Comment on attachment 238879 [details] [diff] [review]
be daring

I'm not a content peer...
Attachment #238879 - Flags: superreview?(neil)
Attachment #238879 - Flags: superreview+
Attachment #238879 - Flags: review?(neil)
Attachment #238879 - Flags: review?(bzbarsky)
Comment on attachment 238879 [details] [diff] [review]
be daring

Yeah, looks good.
Attachment #238879 - Flags: review?(bzbarsky) → review+
Comment on attachment 238879 [details] [diff] [review]
be daring

mozilla/layout/xul/base/src/nsBoxObject.cpp 	1.64
Attachment #238879 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.