352063 - Regression error, setting browser.startup.homepage_override.mstone to ignore no longer works

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Harry Johnston]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060910 Minefield/3.0a1

The patch for Bug 324093 removed existing functionality by no longer checking for the special case "ignore" in the user's browser.startup.homepage_override.mstone setting.  Note that the patch in question has landed on the trunk but not the 1.5 or 2.0 branches.


Reproducible: Always

Steps to Reproduce:
Set browser.startup.homepage_override.mstone to ignore in the user's preferences.  Restart the browser.
Actual Results:  
The override homepage is shown.

Expected Results:  
The user's home page should be shown.

See also Bug 351260.  It is perhaps only necessary to fix one or the other of these two bugs.

Comment 1

[Harry Johnston]

Attachment: proposed patch

I still prefer the fix I proposed in Bug 351260, but as people may be using the existing functionality it should probably be retained. (?)

Comment 2

[Ria Klaassen (not reading all bugmail)]

I see this only since Bug 314119.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 237640 [details] [diff] [review]
proposed patch

Indeed, this long-standing (though not very pretty) option should not have been removed.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 237640 [details] [diff] [review]
proposed patch

No superreview is needed for /browser patches. I'll try get this landed sometime soon.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Sorry that I took so long to get this checked in, I've been busy with other Firefox 2 stuff. Checked in on the trunk.
mozilla/browser/components/nsBrowserContentHandler.js 	1.27

(note to myself: this was caused by the patch in bug 324093)