35207 - If I edit link properties, SAVE is still greyed out

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Mike Cornall]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (X11; I; Linux 2.2.14 i686)
BuildID:    2000040708

The SAVE icon does not become active when I edit the properties of an existing
link (though I can overcome this by typing into regular text). If my only
changes are to link properties, I can exit Composer, and I lose my changes
without warning.

Reproducible: Always
Steps to Reproduce:
1. Open an existing page in Composer.
2. Click on an existing link.
3. Click on the LINK icon to bring up the properties.
4. Make changes in the "Link text" or "Link to" fields.
5. Click on OK.
6. Try to click on SAVE.

Actual Results:  The SAVE icon is still greyed out, and clicking on it does not
save the file. Clicking on the close button shuts down Composer without saving
the file, and without a "do you want to save?" dialog.

Expected Results:  Changes to link properties should activate the "modified"
mode, like any other changes.

The problem also occurs in Milestone 14.

Comment 1

[rubydoo123]

using the build from 10 APR, on win95, the Save icon is greyed out, but when it 
is selected the Save dialog is displayed. On linux, the Save icon is greyed out, 
but on selection it displays the Save dialog. On mac, the Save icon is greyed 
out, and selecting it does not display the Save dialog.

Comment 2

[Mike Cornall]

In my scenario, I don't see the save dialogue when I select the greyed-out Save
icon, but that makes sense because I'm editting an existing file. However, I
checked again, and it turns out that selecting the greyed-out Save icon does, in
fact, save my changes. It was too fast for me see, and, obviously, my statement
that it wouldn't save the file was an assumption (bad programmer, bad).

The other points -- the Save icon being greyed out, and being able to quit and
lose your changes -- are still valid.

Of course, this brings up an interesting question. Should it be possible to save
the file by clicking on a greyed-out icon?

Comment 3

[Kathleen :Brade]

I see this on macintosh; platform/os -> All

Comment 4

[Charles Manske]

Two issues: clicking on grayed out buttons issues the command (obviously it
shouldn't). The Save button should be enabled after any editing change.
Any changes made by using the link dialog to throught the normal transaction
methods for inserting nodes and changing attributes, which i thought should
trigger setting the doc 'dirty'.
Since Simon wrote the "dirty" detection system, I'll let him look at it.

Comment 5

[Simon Fraser [no longer active]]

Clicks on disabled buttons executing the command is a different bug (filed?) and 
should not be covered here.

Comment 6

[Simon Fraser [no longer active]]

Back to you, Charlie. The deal is that changing link properties does not go 
through the transaction system.

Comment 7

[Charles Manske]

Oops! Indeed, nsEditor::CloneAttributes() didn't use transactions! 
Fix is in my tree.
Note that you will see similar behavior (i.e., "Save" isn't enabled after 
attribute change) for all the property dialogs until this is checked in.

Comment 8

[Charles Manske]

Checkin in 4/12

Comment 9

[sujay]

verified in 4/26 build.