352106 - Moving search engines up and down does not work right

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[alex]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

Today I added some search engines, and removed some of the default. When i tried to rearrange the order my search engines after clicking OK the search engines were not ordered in the way i wanted them. Finally after moving an engine which resulted in moving an entirely different one i managed to order them in the way i want

Reproducible: Always

Steps to Reproduce:
1.Add some search engines
2.Remove some (of the default?) search engines
3.Move a search engine
4.Click OK and go see how the engines are ordered

Actual Results:  
The engines are not ordered in "manage search engines"

Expected Results:  
The engines should be ordered in the way in "manage search engines"

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Steps to reproduce:
1) Add an engine (any engine)
2) Delete all engines other than Google and the added engine
3) Try to move Google below the added engine

This happens because the engine manager does not take into account "hidden" engines when finding the old/new index for the move.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.83
mozilla/browser/components/search/nsIBrowserSearchService.idl 	1.16

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 238128 [details] [diff] [review]
patch

This is a low risk patch that only affects search engine ordering. The indices passed by the engine manager were based on the visible engine list, while the search service treated the incoming index as though it was based on the list of all engines (including hidden engines). This patch fixes that discrepancy so that ordering works correctly when you have a hidden default engine.

Comment 5

[Mike Schroepfer]

Comment on attachment 238128 [details] [diff] [review]
patch

a=schrep for 181drivers

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsIBrowserSearchService.idl 	1.1.2.17
mozilla/browser/components/search/nsSearchService.js 	1.1.2.67