Closed Bug 352132 Opened 14 years ago Closed 14 years ago

[@ CNavDTD::HandleSavedTokens] possibly null mSink is dereferenced

Categories

(Core :: DOM: HTML Parser, defect, critical)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, crash, klocwork)

Crash Data

Attachments

(1 obsolete file)

 
Attached patch bail early per file style (obsolete) — Splinter Review
Assignee: mrbkap → timeless
Status: NEW → ASSIGNED
Attachment #238878 - Flags: review?(mrbkap)
Comment on attachment 238878 [details] [diff] [review]
bail early per file style

Sure, I guess. At some point it might be nice to prove that all of these null checks are unnecessary (how can we ever get here with a null sink?) but that's another problem for another time.
Attachment #238878 - Flags: review?(mrbkap) → review+
Attachment #238878 - Flags: superreview?(bzbarsky)
Attachment #238878 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 238878 [details] [diff] [review]
bail early per file style

mozilla/parser/htmlparser/src/CNavDTD.cpp 	3.489
Attachment #238878 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Crash Signature: [@ CNavDTD::HandleSavedTokens]
You need to log in before you can comment on or make changes to this bug.