Closed Bug 35215 Opened 26 years ago Closed 26 years ago

CSS Scanner accepts HTML-esque comments

Categories

(Core :: CSS Parsing and Computation, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: css1, testcase, Whiteboard: fix in hand(py8ieh:snarf testcase for eviltests))

Attachments

(1 file)

DESCRIPTION: The part of the CSS scanner that does comment parsing doesn't care how many dashes are in the CDO and CDC tokens that it ignores. However, it should only ignore the tokens when there are exactly two dashes: "<!--" and "-->". STEPS TO REPRODUCE: * load attached test case ACTUAL RESULTS: * lines are red and green EXPECTED RESULTS: * lines should be the default color DOES NOT WORK CORRECTLY ON: * Linux, mozilla, 2000-04-07-08-M15 ADDITIONAL INFORMATION: The problem is reasonably clear if you look at anything associated with the dashCount variable in nsCSSScanner::Next.
Whiteboard: (py8ieh:snarf testcase for eviltests)
I have a fix for this. Stealing bug...
Assignee: pierre → dbaron
Target Milestone: --- → M16
Status: NEW → ASSIGNED
Whiteboard: (py8ieh:snarf testcase for eviltests) → fix in hand(py8ieh:snarf testcase for eviltests)
Fix checked in 2000-04-26 17:12 PDT.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
As per meeting with ChrisD today, taking QA.
QA Contact: chrisd → py8ieh=bugzilla
The test case reliably crashes on both Win2K and Linux. I will file a new bug.
VERIFIED FIXED with Windows 2000 and Linux Commercial builds 20000090808.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: