352162 - New version of 3D effect on endcap buttons is too subtle to see

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060911 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060911 BonEcho/2.0b2

After today's Winstripe Rollup, go and search buttons no longer have the 3D effect.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

Also the outline of the searchbar-engine-button is a bit pale.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Myk thinks that he actually did this when fixing an RTL issue. Assigning to him.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 352152 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: top is beta2, bottom is 20060911 nightly

... bottom is wrong ;)

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #2)
> Myk thinks that he actually did this when fixing an RTL issue. Assigning to
> him.

Actually, the RTL issue I fixed was that the missing left border on the textbox stayed on the left in RTL mode.  I made it move to the right in RTL mode.  But that's because I thought it was missing on purpose.  Turns out it was supposed to be there all along (and was there on Windows).

Now that it's also missing on Windows, at least Windows and Linux are consistent (perhaps because of the big theme rollup or because of the fix for bug 351195), which should make the fix easier.  Looking...

Comment 6

[Mike Connor [:mconnor]]

This was an image mixup. RC is on it.

Comment 7

[ronin.achilles]

This Bug has been marked FIXED but I don't see it fixed in the latest Nightly. Its the same as yesterday. Request to Reopen.

Comment 8

[Marco Bonardo [:mak]]

in winstripe, hover state in search engine selection dropdown button is almost EQUAL to normal state, so it feels as it's not reacting to mouse hover, maybe search engine icon should be dimmed.

Comment 9

[Ria Klaassen (not reading all bugmail)]

Everything looks alright to me, only the border between the search-engine-button and the text field is missing. When I delete the line -moz-margin-end: -1px; the border is visible again.

Comment 10

[Adam Guthrie]

*** Bug 352350 has been marked as a duplicate of this bug. ***

Comment 11

[ronin.achilles]

(In reply to comment #9)
> Everything looks alright to me, only the border between the
> search-engine-button and the text field is missing. When I delete the line
> -moz-margin-end: -1px; the border is visible again.
> 

If you compare the current state of Go/Search buttons to the ones that existed before 10/11 builds, you would notice that the earlier builds had these buttons exhibiting a 3D effect wherein the entire button responded to Hover and Click. With the current build, only the icons in the Go/Search button respond to hover/click and not the entire button. The Search Engine button does not even respond to hover. 
And even in the normal state all the three buttons had decent gradients whereby they had the 3D look. Now they look flat and 2D.
This is definitely a regression from yesterday but I can't point out the exact bug that caused it.

Comment 12

[Peter Kasting]

Removing fixed1.8.1 keyword until this is resolved

Comment 13

[Peter Kasting]

On my latest build, it looks like there's a 3D effect for the entire button on all these endcaps, but it's VERY subtle.  So perhaps this bug is really "new version of 3D effect on endcap butons is too subtle to see"?  I haven't compared against a severl-days-old nightly to see what the difference is.

Comment 14

[ronin.achilles]

In reply to comment #13)
> On my latest build, it looks like there's a 3D effect for the entire button on
> all these endcaps, but it's VERY subtle.  So perhaps this bug is really "new
> version of 3D effect on endcap butons is too subtle to see"?  I haven't
> compared against a severl-days-old nightly to see what the difference is.

I agree. Its too subtle to the extent of being virtually non-existent. Besides the hover, even the normal state gradient seems to have regressed.

Changing Summary to reflect the problem more precisely.

Comment 15

[Peter Kasting]

Shortening summary even more.  This may be more appropriately spun off into a different bug or minused for blocking; it's really a bugmorph of the original bug.

Comment 16

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot

In this screenshot I replaced the Search-provider-bkgnd.png image by the previous image (used until a few days ago, I guess they changed the image) and when also the border is corrected, it seems identical again to me.
Or should there be made an even better image?

Comment 17

[Jay Goldman]

The 3D effect has been reduced because the image needs to be much more transparent than it originally was, in order to allow background colours to show through the PNG for supporting Windows themes other than Luna. I don't know that we can fix this and keep support for that and I think supporting other themes is a higher priority. Connor/Beltzner?

Comment 18

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot comparison

Comparison new image - old image (search) in windows classic, both in hover state, with border.

Comment 19

[ronin.achilles]

(In reply to comment #17)
> The 3D effect has been reduced because the image needs to be much more
> transparent than it originally was, in order to allow background colours to
> show through the PNG for supporting Windows themes other than Luna. I don't
> know that we can fix this and keep support for that and I think supporting
> other themes is a higher priority. Connor/Beltzner?
> 

I am not sure about that. The go/search endcap images as they stood on or before 09/10 build did pick the theme color across all themes (Luna/Royale/Classic are the ones I have seen). The borders have been smoothened between then and now (which look good) but since those images were transparent enough, I don't see as to why they should have been changed. Can't we revert back to those images keeping the borders as they are now?

Comment 20

[Mike Connor [:mconnor]]

Discussed with beltzner, we're ok with the current, more subtle, look of the endcaps.  

Comment 21

[ronin.achilles]

(In reply to comment #20)
> Discussed with beltzner, we're ok with the current, more subtle, look of the
> endcaps.  
> 

I guess then we will just go with it as it is, but this was something which worked so nicely ever since it landed about a month and a half back, it looked nice and was liked by everyone, infact of all the negative remarks about the theme across forums, the new Go and Search buttons was something which was never criticized (in terms of their looks and effects). This thing got regressed two days back and now its been decided not to fix it. I really am surprised with this decision. 

I really hope you do reconsider it, coz these 'subtle' effects are infact so subtle that the endcaps have started to look like 2D drawing. There is no explicit pressed state for either of these buttons (only the icons within the buttons look like they have been pressed), the remaining area looks as if its absolutely stationary after hover.

IMO this was one of the best changes to the theme in terms of looks and effects which now stands greatly compromised.

Comment 22

[ronin.achilles]

If nothing too complicated, can we atleast checkin a set of images to reflect a more pronounced 'Pressed' state. Right now, only the icons (i.e. arrow in Go button and Lens icon in Search button) have the pressed effect while ideally the entire button area should look pressed. Just this much should improve the two buttons a whole lot.
Thanks.

Comment 23

[Matt Cosentino]

The original images worked great with other themes, that was never a problem.  Now it just looks bad in any theme, including Luna.  It was the best looking part of the theme, and I know I'll be very disappointed if it stays in it's current state.

At the very least, give them a pressed state.  The urlbar dropdown has one, so it should at least match that.