352235 - Use Bugzilla->localconfig everywhere instead of :localconfig from Bugzilla::Config

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Basically it's what the summary says. I want to use Bugzilla->localconfig everywhere instead of importing the :localconfig vars from Bugzilla::Config. This shouldn't be too hard.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay. I had to make a few modifications to Bugzilla::Install::Localconfig, because otherwise it was running the "_get_default" subroutines every time.

Comment 2

[Frédéric Buclin]

Comment on attachment 237848 [details] [diff] [review]
v1

seems to work like a charm. r=LpSolit

Comment 3

[Max Kanat-Alexander]

Checking in testserver.pl;
/cvsroot/mozilla/webtools/bugzilla/testserver.pl,v  <--  testserver.pl
new revision: 1.14; previous revision: 1.13
done
Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.68; previous revision: 1.67
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.88; previous revision: 1.87
done
Checking in Bugzilla/Attachment/PatchReader.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment/PatchReader.pm,v  <--  PatchReader.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/Install/Localconfig.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Localconfig.pm,v  <--  Localconfig.pm
new revision: 1.6; previous revision: 1.5
done

Comment 4

[Frédéric Buclin]

Comment on attachment 237848 [details] [diff] [review]
v1

>Index: testserver.pl

>-BEGIN {
>-    my $envpath = $ENV{'PATH'};
>-    require Bugzilla;
>-    $ENV{'PATH'} = $envpath;
>-}
>-
>+use Bugzilla;


We should back out this change. testserver.pl is now broken:

TEST-WARNING Failed to find the GID for the 'httpd' process, unable
to validate webservergroup.