don't override border on toolbarbuttons (restore bevel when using Classic)

RESOLVED FIXED in Firefox 2

Status

()

Firefox
General
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2
x86
Windows XP
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change])

Attachments

(1 attachment)

Bug 348442 restored the -moz-appearance styling, which restored the native hover/active effects (bevel) for the themed cases (Luna), but didn't remove the explicit border overriding, so Classic users still don't have "native" bevels.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P1
Whiteboard: [Fx2 theme change]
Created attachment 237863 [details] [diff] [review]
patch

This doesn't affect appearance on Luna since the -moz-appearance rules already override the border there. This does however increase the spacing between buttons when using classic, due to the border. That padding discrepancy (Classic vs. Luna) also existed in 1.5, though, so I don't think it's an issue.
Attachment #237863 - Flags: review?(mconnor)
Whiteboard: [Fx2 theme change] → [patch-r?][Fx2 theme change]
Comment on attachment 237863 [details] [diff] [review]
patch

great, thanks Gavin!

I should have tested this better, but I hit the nightly cutoff and landed stuff.
Attachment #237863 - Flags: review?(mconnor)
Attachment #237863 - Flags: review+
Attachment #237863 - Flags: approval1.8.1+
mozilla/browser/themes/winstripe/browser/browser.css 	1.17.2.55
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [patch-r?][Fx2 theme change] → [Fx2 theme change]

Updated

12 years ago
Flags: blocking-firefox2?

Comment 4

12 years ago
I just downloaded the latest hourly and while the bevels are back on Back/Forward buttons on Classic, there are no bevels on the Back/Forward Dropmarkers.
(In reply to comment #4)
> I just downloaded the latest hourly and while the bevels are back on
> Back/Forward buttons on Classic, there are no bevels on the Back/Forward
> Dropmarkers.

That's consistent with Firefox 1.5. Feel free to file a new bug on it, if there isn't one already.

Comment 6

12 years ago
(In reply to comment #5)
> (In reply to comment #4)
> > I just downloaded the latest hourly and while the bevels are back on
> > Back/Forward buttons on Classic, there are no bevels on the Back/Forward
> > Dropmarkers.
> 
> That's consistent with Firefox 1.5. Feel free to file a new bug on it, if there
> isn't one already.
> 

Filed Bug 352292
You need to log in before you can comment on or make changes to this bug.