Cleanup/optimise ReparentFrameView/ReparentFrameViewList code

RESOLVED WONTFIX

Status

()

Core
Layout: Block and Inline
--
enhancement
RESOLVED WONTFIX
12 years ago
11 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

12 years ago
Spawned off from bug 351225
Note: removing the view code will likely make this bug obsolete.


ReparentFrameView/ReparentFrameViewList can be rewritten to share code:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsHTMLContainerFrame.cpp&rev=3.219&root=/cvsroot&mark=416-460,475-520#410

There are several places where I think we could use ReparentFrameViewList
instead of looping sibling lists calling ReparentFrameView, eg:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsContainerFrame.cpp&rev=1.262&root=/cvsroot&mark=996-998,1029-1031#978
It seems unnecessary to calculate the ancestor views on every iteration...
(there are a few other places as well)
(Assignee)

Comment 1

11 years ago
I don't think this is worth doing since views are eventually going away.

-> WONTFIX
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.