Closed Bug 352300 Opened 18 years ago Closed 17 years ago

Cleanup/optimise ReparentFrameView/ReparentFrameViewList code

Categories

(Core :: Layout: Block and Inline, enhancement)

Product:
Core
Component:
Layout: Block and Inline
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

(Depends on 1 open bug)

Details

Spawned off from bug 351225
Note: removing the view code will likely make this bug obsolete.


ReparentFrameView/ReparentFrameViewList can be rewritten to share code:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsHTMLContainerFrame.cpp&rev=3.219&root=/cvsroot&mark=416-460,475-520#410

There are several places where I think we could use ReparentFrameViewList
instead of looping sibling lists calling ReparentFrameView, eg:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsContainerFrame.cpp&rev=1.262&root=/cvsroot&mark=996-998,1029-1031#978
It seems unnecessary to calculate the ancestor views on every iteration...
(there are a few other places as well)
I don't think this is worth doing since views are eventually going away.

-> WONTFIX
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.