email composer loses all keystrokes while saving draft

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Bienvenu)

Tracking

({dataloss})

Trunk
x86
Windows XP
dataloss

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

New regression.  100% repeatable with 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) \
    Gecko/20060824 SeaMonkey/1.5a
Not seen with Seamonkey trunk version from 20060702.

Whie composing email, when SeaMonkey goes to see if there is any new email,
The recipient address portion of the composer window goes gray, a progress
meter appears in composer status bar, and all keystrokes typed while this
is going on are lost.
(Reporter)

Comment 1

11 years ago
The problem occurs while composing email in a composition window for my
IMAPS account.  

I have configured SeaMonkey to "Automatically save the message every 5 minutes".
The workaround is to disable that feature. :(

So, about every 5 minutes, it saves a copy to my IMAPS server.  While it is 
doing so, the composer silently loses all keystrokes being entered.  
Since I don't always look at the screen while typing, I don't always notice 
the missing characters from the body of the message I type.

I never noticed this before upgrading to the 20060824 SeaMonkey build.
Summary: email composer loses all keystrokes during biff → email composer loses all keystrokes while saving draft
(Assignee)

Comment 2

11 years ago
this is a trunk build? I fixed this a while ago, though I'm not sure if the code was shared between SM and TB - I can double check. 
(Reporter)

Comment 3

11 years ago
Yes, Seamonkey trunk build.
(Assignee)

Comment 4

11 years ago
see bug 323351 for the TB fix - the same thing should work for Seamonkey.
(Reporter)

Comment 5

11 years ago
So, this is a SeaMonkey bug, not a core bug, I gather.
Assignee: nobody → mail
Component: MailNews: Composition → MailNews: Main Mail Window
Product: Core → Mozilla Application Suite
QA Contact: composition
(Assignee)

Comment 6

11 years ago
yes, it's a SM bug - if you can't get any traction from the SM guys, let me know and I can try to get to it. But it would be easier if a Seamonkey person tried to port that patch.
(Reporter)

Comment 7

11 years ago
David, I want to take you up on your offer (in comment 6 ).  
Please, and thanks!
(Assignee)

Comment 8

11 years ago
Created attachment 243685 [details] [diff] [review]
patch against the seamonkey trunk

I haven't tried running with this patch (my SM build is still going) but it should work the same as in TB.
Attachment #243685 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #243685 - Flags: review? → review?(neil)

Comment 9

11 years ago
Comment on attachment 243685 [details] [diff] [review]
patch against the seamonkey trunk

>+        gAutoSaving = (msgType == nsIMsgCompDeliverMode.AutoSaveAsDraft);
Nit: don't need these ()s

>+        // disable the ui if we're not auto-saving
>+        if (!gAutoSaving)
>+        {
>+          gWindowLocked = true;
>+          disableEditableFields();
>+          updateComposeItems();
>+        }
>+        // if we're auto saving, mark the body as not changed here, and not
>+        // when the save is done, because the user might change it between now
>+        // and when the save is done.
>+        else 
>+          SetContentAndBodyAsUnmodified();
Nit: inverted conditions with else clauses can be confusing. Prefer:
// if we're auto saving, mark the body as not changed here, because
// the user might change it between now and when the save completes
if (gAutoSaving)
  SetContentAndBodyAsUnmodified();
else
{
  // disable the ui if we're really saving
  etc.
}
Attachment #243685 - Flags: review?(neil) → review+
(Assignee)

Comment 10

11 years ago
Created attachment 243723 [details] [diff] [review]
address Neil's comments...

Scott, can you sr this SM patch? It's just ported from TB and will hopefully make Nelson's life a little easier :-)
Assignee: mail → bienvenu
Attachment #243685 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #243723 - Flags: superreview?(mscott)

Comment 11

11 years ago
Comment on attachment 243723 [details] [diff] [review]
address Neil's comments...

happy to review a back port to seamonkey.
Attachment #243723 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 12

11 years ago
fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

11 years ago
Many thanks to you, David, Neil and Scott.  
I owe you all a beer (or equivalent :)

Updated

10 years ago
Duplicate of this bug: 396094
You need to log in before you can comment on or make changes to this bug.