Closed
Bug 352323
Opened 18 years ago
Closed 18 years ago
the scroll right button doesn't appear disabled like the scroll left
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: moco, Assigned: moco)
References
Details
(Keywords: access, fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(5 files)
17.23 KB,
image/png
|
Details | |
39.69 KB,
image/bmp
|
Details | |
16.05 KB,
image/png
|
Details | |
11.10 KB,
image/png
|
Details | |
5.33 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
the scroll right button doesn't appear disabled like the scroll left (and vice versa when in RTL mode). this does not require new images from dao, but I think I have a way to fix it.
Assignee | ||
Comment 1•18 years ago
|
||
Assignee | ||
Comment 2•18 years ago
|
||
this is also important for high contrast mode.
Updated•18 years ago
|
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Comment 3•18 years ago
|
||
Assignee | ||
Comment 4•18 years ago
|
||
Assignee | ||
Comment 5•18 years ago
|
||
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #238280 -
Flags: review?
Assignee | ||
Updated•18 years ago
|
Attachment #238280 -
Flags: review? → review?(mconnor)
Comment 7•18 years ago
|
||
Comment on attachment 238280 [details] [diff] [review] patch Yeah, I'm sold. Let's get this in!
Attachment #238280 -
Flags: review?(mconnor)
Attachment #238280 -
Flags: review+
Attachment #238280 -
Flags: approval1.8.1+
Assignee | ||
Comment 8•18 years ago
|
||
note, the reason for the image change is the original images were inconsistent. see http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/winstripe/global/icons/tab-arrow-end.png, look at the third arrow from the left (it looks more like a pinstripe arrow than a the other winstripe arrows.)
Assignee | ||
Comment 9•18 years ago
|
||
fix landed on the trunk. I'll go land the non theme part on the trunk before marking this fixed.
Keywords: fixed1.8.1
Assignee | ||
Comment 10•18 years ago
|
||
actually, not able to land on the trunk yet because the theme changes (including changes to tabbrowser.xml for the tabbrowser-arrowscrollbox binding) are not on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 11•5 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•