352357 - Remove unused XP roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Håkan Waara]

Two unused roles can be removed:

* ROLE_INTERNAL_FRAME
* ROLE_EMBEDDED

Comment 1

[Håkan Waara]

I found two other XP roles that are dups: ROLE_WHITESPACE and ROLE_FILLER. Should I remove one of them?

Comment 2

[Aaron Leventhal]

Yes, remove ROLE_FILLER.

Comment 3

[Håkan Waara]

Attachment: Patch to msaa/atk & nsIAccessible.idl

This removes it from all rolemaps (except mac's, which I will include with the other changes in bug 352327).

Comment 4

[Evan Yan]

after remove the roles, the role is not correcly mapped, and got this:

###!!! ASSERTION: ATK role map skewed: 'atkRoleMap[nsIAccessible::ROLE_LAST_ENTRY] == kROLE_ATK_LAST_ENTRY', file ../../../../mozilla/accessible/src/atk/nsAccessibleWrap.cpp, line 823

Comment 5

[Evan Yan]

Attachment: add placeholder for the roleMap array

Comment 6

[Håkan Waara]

Comment on attachment 239295 [details] [diff] [review]
add placeholder for the roleMap array

Gah, I can't believe I didn't see this. Ok, so I suppose it's easier to use placeholders than to change all the nsIAccessible constants.

Please fix mac too though. You can use NSAccessibilityUnknownRole for the placeholders.

Comment 7

[Evan Yan]

Attachment: also add fix for mac

Comment 8

[Evan Yan]

Comment on attachment 239333 [details] [diff] [review]
also add fix for mac

Aaron, to fix the bug, we can add placeholder as the patch does, or change the constants in nsIAccessible.

which one do you prefer?

Comment 9

[Aaron Leventhal]

Comment on attachment 239333 [details] [diff] [review]
also add fix for mac

Sorry I missed this in the review. At least we have the assertion!

I suggest removing the gaps out of the nsIAccessible constants instead, this is a bit strange.

Comment 10

[Håkan Waara]

Attachment: Fix nsIAccessible.idl constants to be continous

This makes all nsIAccessible role constants be continous, since the value of a constant is used to access the Nth element in our rolemap arrays. There must be no gaps.

Comment 11

[Håkan Waara]

Checked in. Can you guys verify that win32 and atk are OK now? 

When they are, let's close the bug.

Comment 12

[Evan Yan]

verified on linux