352400 - Update wizard sometimes flashes a large textbox (really, a blank xul:browser) when showing the details for a minor update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Dietrich Ayala (:dietrich)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b2) Gecko/20060911 BonEcho/2.0b2

When I the update page loads (after clicking "check for updates"), there's a flash of what looks like a large textbox.

STR:

1. Wait until there's an update
2. Open Help/Check for Updates...

Expected Results: No flash of a big textbox.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this a dupe of bug 350490?

Comment 2

[(not reading, please use [e-mail] instead)]

not sure if it is a dup.  if it looks like a large textbox, it must be the xul:browser that is used for loading details, but that is only for major updates.

is this a recent problem, or has it been happening for a while.

dietrich, anything special about your profile, like lots of extensions?

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> not sure if it is a dup.  if it looks like a large textbox, it must be the
> xul:browser that is used for loading details, but that is only for major
> updates.
> 
> is this a recent problem, or has it been happening for a while.

the 9/11 build is the first time i'd noticed it.

> dietrich, anything special about your profile, like lots of extensions?
> 

20+ extensions, with about half of them disabled.

Comment 4

[(not reading, please use [e-mail] instead)]

> the 9/11 build is the first time i'd noticed it.

thanks for that info.  the checkins to the update code don't point to anything immediately (see http://bonsai.mozilla.org/cvsquery.cgi?branch=MOZILLA_1_8_BRANCH&file=mozilla/toolkit/mozapps/update/&date=week)

> 20+ extensions, with about half of them disabled.

interesting.  as with bug #350490, having lots of extensions could make things worse as it could delay the processing time.

Comment 5

[(not reading, please use [e-mail] instead)]

dietrich, do you still see this?

Comment 6

[Dietrich Ayala (:dietrich)]

I updated a few times today, branch and trunk for both mac and win, and did not notice this again. Were there any recent changes that might've affected this?

Comment 7

[(not reading, please use [e-mail] instead)]

> Were there any recent changes that might've affected this?

none that I can think of, but looking at the code, it seems like a good idea for me to move the "detailsDeck.selectedIndex = 1;" to the end of onShowMoreDetails().

I mentioned this back in https://bugzilla.mozilla.org/show_bug.cgi?id=350490#c5, but forgot about it, and failed to do it for FF2.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: screen shot, if I hack a "return" into onShowMoreDetails()

Comment 9

[(not reading, please use [e-mail] instead)]

dietrich, does that last screen shot resemble what you saw?  (I hope so!)

I can reproduce what I think is the problem if I do this:

 onShowMoreDetails: function() {
   var detailsDeck = document.getElementById("detailsDeck");
   detailsDeck.selectedIndex = 1;

+  return; // hack!

so, I think by moving "detailsDeck.selectedIndex = 1;" to the end of onShowMoreDetails(), I can avoid this problem.

What the user would see (after I make this change), if they ran into this bug, is your new UI from bug #352675:  the throbber and the "Checking if this update will cause problems with your extensions and/or themes..." text.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 11

[Dietrich Ayala (:dietrich)]

Comment on attachment 239526 [details] [diff] [review]
patch

(In reply to comment #9)
> dietrich, does that last screen shot resemble what you saw?  (I hope so!)
> 

yeah, that's probably what i saw. i could reproduce it w/ my daily profile (lots o' extensions) in today's branch build.

r=me on the patch.

Comment 12

[(not reading, please use [e-mail] instead)]

drivers:  If possible, could this be a ride along if we do a FF2 RC2?  Here's why I think we want this.

for 2.0, the detailsDeck is new.  For slower machines, it appears possible that users will see the flash of the <xul:browser> when we have minor updates.

this low risk fix will prevent that flash.

Comment 13

[(not reading, please use [e-mail] instead)]

> i could reproduce it w/ my daily profile

just to clarify:  could or could not?

Comment 14

[(not reading, please use [e-mail] instead)]

dietrich, thanks for the prompt review.  I'm going to get this on the trunk first, and then beg drivers to let me ride along for FF2 RC2 (if there is one.)

Comment 15

[Dietrich Ayala (:dietrich)]

(In reply to comment #13)
> > i could reproduce it w/ my daily profile
> 
> just to clarify:  could or could not?
> 

*could* 

I saw the flash when updating to today's branch nightly.

Comment 16

[(not reading, please use [e-mail] instead)]

fix checked into the trunk, setting tm to ff3a1, but hoping drivers let me backport the fix to the branch.

Comment 17

[(not reading, please use [e-mail] instead)]

since the detailsDeck and the <license> xul:browser are new, this is a regression.

Comment 18

[Mike Schroepfer]

Seth - yeah lets get this for 181RC2.

Comment 19

[Reed Loden [:reed]]

Comment on attachment 239526 [details] [diff] [review]
patch

Requesting approval1.8.1, as per comment #18.

Comment 20

[Mike Schroepfer]

Comment on attachment 239526 [details] [diff] [review]
patch

Approved for RC2.

Comment 21

[(not reading, please use [e-mail] instead)]

schrep: thanks for the ride along approval.

fix landed on the branch.

this is something we can verify on the nightlies, as on the nightly update channel we provide minor updates.

dietrich, since you were seeing this, can you keep an eye out for it?  You'll need one update to get the fix, and then after that, you should see the improvement.

Comment 22

[(not reading, please use [e-mail] instead)]

> dietrich, since you were seeing this, can you keep an eye out for it?

darn, I just saw it on Mac OS X when getting the minor update for tbird.  I was running tbird 2 beta 1 (20060930), which is built from the MOZILLA_1_8_BRANCH.

I saw the large text box / blank xul:browser flash by.  It was a very small update, perhaps that could be part of the trick to reproduce this issue.

re-opening and clearing keywords.

note, I haven't seen this on windows yet.

Comment 23

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.

Comment 24

[Wayne Mery (:wsmwk)]

is there any reason to believe this still exists, besides comment 22?

Comment 25

[Robert Strong (they/them - no direct email)]

Dietrich, are you still able to reproduce?

Comment 26

[Ed Morley [:emorley]]

Closing per whiteboard closeme date since no reply to last comment/fix has already landed on m-c.