Reference leaks in modutil

RESOLVED FIXED in 3.12

Status

NSS
Tools
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Julien Pierre, Assigned: Julien Pierre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Running some modutil commands, I ran into many assertions due to reference leaks on shutdown with NSS_STRICT_SHUTDOWN enabled (which I always have in my .cshrc). They are caused by some calls to SECMOD_FindModule without a corresponding SECMOD_DestroyModule . Patch forthcoming .
(Assignee)

Comment 1

11 years ago
Created attachment 238122 [details] [diff] [review]
Call SECMOD_DestroyModule where needed
Attachment #238122 - Flags: superreview?(nelson)
Attachment #238122 - Flags: review?(alexei.volkov.bugs)
(Assignee)

Comment 2

11 years ago
More testing is needed in this area. We don't test the list, rawlist, enable, set default, unset default options of modutil in all.sh .
QA Contact: tools → slavomir.katuscak
(Assignee)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.11.4

Comment 3

11 years ago
Comment on attachment 238122 [details] [diff] [review]
Call SECMOD_DestroyModule where needed

r=alexei.volkov
Attachment #238122 - Flags: review?(alexei.volkov.bugs) → review+
(Assignee)

Comment 4

11 years ago
Checking in pk11.c;
/cvsroot/mozilla/security/nss/cmd/modutil/pk11.c,v  <--  pk11.c
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
OS: SunOS → All
Resolution: --- → FIXED
Target Milestone: 3.11.4 → 3.12
(Assignee)

Updated

11 years ago
Attachment #238122 - Flags: superreview?(nelson)
You need to log in before you can comment on or make changes to this bug.