352441 - Decompilation of "case (yield):" does not compile

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

js> function() { switch (x) { case (yield): } }
function () {
    switch (x) {
      case yield:
      default:;
    }
}

js> function () { switch (x) { case yield: } }
syntax error

Comment 1

[Jesse Ruderman]

Is this a bug in the decompiler or a bug in the compiler?

Why is "case yield:" a syntax error while "case yield 5:" is accepted?

Comment 2

[Brendan Eich [:brendan]]

I think case yield: should not be an error.  The E262-3 grammar says a case label is an Expression (Expr in jsparse.c terms).  There's no problem with , as in an argument list.  Comments?

/be

Comment 3

[Jesse Ruderman]

js> new Function("switch(w) { case yield\n: x }")

somehow compiles, but its decompilation of course doesn't compile.

Comment 4

[Jesse Ruderman]

WFM: "case yield:" is now accepted.

Comment 5

[Jesse Ruderman]

D'oh, I was testing without "-v 170".

Comment 6

[Brendan Eich [:brendan]]

Attachment: fix

Comment 7

[Brendan Eich [:brendan]]

Fixed on trunk:

js/src/jsparse.c 3.275

/be

Comment 8

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_7/decompilation/regress-352441.js,v  <--  regress-352441.js
initial revision: 1.1

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed on trunk.